FabricMC / fabric-loader

Fabric's mostly-version-independent mod loader.
Apache License 2.0
634 stars 270 forks source link

fabric mods not working with mineshafter vanilla loader #113

Closed BeErikk closed 5 years ago

BeErikk commented 5 years ago

I installed the fabric mod loader and a new 1.14 profile showed up. When I start the fabric profile everything seems alright but there are no active mods. I get the "Minecraft 1.14/fabric" logo in the left lower corner. My log looks like this:

[07:57:24] [main/INFO]: [FabricLoader] Loading 1 mod: fabricloader@0.4.2+build.132 [07:57:24] [main/INFO]: SpongePowered MIXIN Subsystem Version=0.7.11 Source=file:/%appdata%/.minecraft/libraries/net/fabricmc/sponge-mixin/0.7.11.23/sponge-mixin-0.7.11.23.jar Service=Knot/Fabric Env=CLIENT [07:57:24] [main/INFO]: Setting user: SockerConny [07:57:29] [main/WARN]: Skipping bad option: textBackgroundOpacity: [07:57:29] [main/INFO]: LWJGL Version: 3.2.1 build 12 [07:57:31] [main/WARN]: Removed resource pack durabilityviewer from options because it doesn't seem to exist anymore [07:57:31] [main/WARN]: Removed resource pack litematica from options because it doesn't seem to exist anymore [07:57:31] [main/WARN]: Removed resource pack malilib from options because it doesn't seem to exist anymore [07:57:31] [main/WARN]: Removed resource pack voxelmap from options because it doesn't seem to exist anymore [07:57:32] [main/INFO]: Narrator library for x64 successfully loaded [07:57:45] [main/INFO]: OpenAL initialized. [07:57:45] [main/INFO]: Sound engine started [07:57:45] [main/INFO]: Created: 1024x512 textures-atlas [07:57:46] [main/INFO]: Created: 256x256 textures/particle-atlas [07:57:46] [main/INFO]: Created: 256x256 textures/painting-atlas [07:57:46] [main/INFO]: Created: 256x128 textures/mob_effect-atlas

The durabilityviewer, litematica and voxelmap are some of my rift 1.13 mods in the root of the mods folder but not all. I also have the durabilityviewer-1.14-fabric0.2.7-1.5 mod and the Hwyla-fabric-1.14-1.9.16-60 but they are not visible in 1.14 fabric client.

liach commented 5 years ago

You need the fabric mod as their prerequisite.

BeErikk commented 5 years ago

Yes, I read something about that so I added fabric-0.2.7+build.127.jar to the root of the mods folder

asiekierka commented 5 years ago

Important question: Should we even be extending effort on our side to support Mineshafter?

liach commented 5 years ago

Hmm, never heard of Mineshafter. Any link?

BeErikk commented 5 years ago

Important question: Should we even be extending effort on our side to support Mineshafter?

First, can you confirm Mineshafter is incompatible with fabric? It is a very easy, simple and light loader, but it is very stable and nice in my experience. Always have it in the Minecraft root. If it is incompatible I assume the changes will be minor. I would love to have it working with fabric. I have no idea if the original author will change the code. To me, it seems there's just some patches to the old version java launcher.

modmuss50 commented 5 years ago

I dont think we should support cracked versions of the game at all!

There doesnt seem to be an issue with the log (try installing fabric-api?)

asiekierka commented 5 years ago

old version java launcher

I'm not even sure if we support that, frankly.

Either way, what are you using Mineshafter for?

BeErikk commented 5 years ago

I believe that's the issue. If you decide to support the old java launcher the problem is likely solved. Mineshafter is perfect whenever you want multiple accounts.

modmuss50 commented 5 years ago

I dont see any point in supporting old launchers? this seems like something you shouldn't really be using anyway.

asiekierka commented 5 years ago

I'm pretty sure it's not even the old Java launcher - my hunch is that Mineshafter doesn't set the CWD correctly... not that it necessarily can.

BeErikk commented 5 years ago

Well, you could support the old launcher and leave the issue to the user.

BeErikk commented 5 years ago

I'm pretty sure it's not even the old Java launcher - my hunch is that Mineshafter doesn't set the CWD correctly... not that it necessarily can.

You are probably right because it needs to be in root

asiekierka commented 5 years ago

I've tested the old Java launcher, and it works correctly. In addition, we are not interested in supporting Mineshafter - we would be more interested in, say, a server-side solution that allows the same paid user to connect multiple times under different pseudonyms to a given server, with certain pre-conditions to prevent account sharing. This would be more fair to both server administrators and Mojang/Microsoft.

BeErikk commented 5 years ago

OK, thanks for your efforts.