FabricMC / fabric-loader

Fabric's mostly-version-independent mod loader.
Apache License 2.0
625 stars 264 forks source link

Provide artifact path, url, hash and size in versions.json #283

Open jordanamr opened 4 years ago

jordanamr commented 4 years ago

Just like in Forge : image

This would make custom launchers maintaining easier :)

modmuss50 commented 4 years ago

I dont think that format is correct above.

we could do it for most libs, however I wouldnt want to do it for intermediary as we have needed to update it during a version cycle (think when mojang re-released 1.16)

The launcher does check the sha1 of the files when launching from the .sha1 file on maven.

jordanamr commented 4 years ago

I dont think that format is correct above.

we could do it for most libs, however I wouldnt want to do it for intermediary as we have needed to update it during a version cycle (think when mojang re-released 1.16)

The launcher does check the sha1 of the files when launching from the .sha1 file on maven.

I took that format from the 1.16.1-forge-32.0.69.json profile file so I think it's correct. Can we get that data from the Fabric Meta HTTP API maybe instead? This is just to make sure we don't query the maven repo for every lib just for integrity checks and for ease of maintaining (getting a json with all the data and then parsing it, just like parsing the forge profile)

modmuss50 commented 4 years ago

The format isnt correct for us anyway, I think we could add this on the meta side of things as it would have a low change of breaking pre existing launchers

https://meta.fabricmc.net/v2/versions/loader/1.16.1/0.8.9+build.203/profile/json

jordanamr commented 4 years ago

This is currently the endpoint I am using to get the json profile, adding the extra data in there would be fabulous for launcher maintainers!

ydainna commented 4 years ago

I think it would be good and that's what I'm looking for

jordanamr commented 4 years ago

Is there any way I can get some guidelines on how to contribute to that meta server so I could PR?

sfPlayer1 commented 4 years ago

The code is here: https://github.com/FabricMC/fabric-meta