search

FabricMC / fabric-loader

Fabric's mostly-version-independent mod loader.
Apache License 2.0
617 stars 262 forks source link

Fabric launcher in dev - create remapped (access fixed) jar as well #465

Open liach opened 3 years ago

liach commented 3 years ago

From https://github.com/FabricMC/tiny-remapper/issues/46#issuecomment-871498309

See https://github.com/FabricMC/fabric-loader/blob/44c957c685bd0bc0160553381e134ac2775330e0/src/main/java/net/fabricmc/loader/impl/transformer/FabricTransformer.java#L49 this package access handling could have been done at https://github.com/FabricMC/fabric-loader/blob/44c957c685bd0bc0160553381e134ac2775330e0/src/main/java/net/fabricmc/loader/impl/launch/FabricLauncherBase.java#L80 to create an access-fixed jar instead.

cc @sfPlayer1 for better suggestions/alternatives if there is any. Does tiny-remapper support mapping back into the same namespace, with only fixing the access of jars? If not, we might get another access detector to handle that.

Chocohead commented 3 years ago

It should be fine running TR without any mappings, rather than making a named -> named set to achieve the same thing