FabricMC / fabric-loader

Fabric's mostly-version-independent mod loader.
Apache License 2.0
610 stars 257 forks source link

NPE in MixinRemapper for Mojang Mappings #596

Closed shartte closed 1 year ago

shartte commented 2 years ago

I am getting a crash in the MixinRemapper at runtime, while trying to use sodium/indium/iris in my dev environment.

It boils down to this:

Caused by: java.lang.NullPointerException: Cannot invoke "String.hashCode()" because "this.descriptor" is null
    at net.fabricmc.mapping.util.EntryTriple.hashCode(EntryTriple.java:85) ~[tiny-mappings-parser-0.3.0+build.17.jar:?]
    at java.util.HashMap.hash(HashMap.java:338) ~[?:?]
    at java.util.HashMap.getNode(HashMap.java:568) ~[?:?]
    at java.util.HashMap.getOrDefault(HashMap.java:1139) ~[?:?]
    at net.fabricmc.mapping.util.MixinRemapper.mapMethodName(MixinRemapper.java:66) ~[tiny-mappings-parser-0.3.0+build.17.jar:?]

Mods used are attached: sodium+indium+iris.zip

Loader 0.12.12, Mojang Mappings, Layered with Parchment

Full stacktrace here: https://gist.githubusercontent.com/shartte/84eee3d5863aa424731d7831f3e08f98/raw/72613a932c1ac1e07a7952a0652c1a340caa868f/gistfile1.txt

modmuss50 commented 1 year ago

I believe this was fixed, if not please open a new issue. Thanks.