search

FabricMC / fabric-loader

Fabric's mostly-version-independent mod loader.
Apache License 2.0
590 stars 253 forks source link

Backend library: LWJGL version does not always match vanilla output #941

Open theofficialgman opened 2 weeks ago

theofficialgman commented 2 weeks ago

output when you use vanilla:

[15:24:12] [Render thread/INFO]: Backend library: LWJGL version 3.1.2 build 29 [15:25:01] [Render thread/INFO]: Backend library: LWJGL version 3.1.6 build 14 [15:25:28] [Render thread/INFO]: Backend library: LWJGL version 3.2.1 build 12 [15:25:57] [Render thread/INFO]: Backend library: LWJGL version 3.2.2 build 10 [15:26:21] [Render thread/INFO]: Backend library: LWJGL version 3.3.1 build 7 [15:32:11] [Render thread/INFO]: Backend library: LWJGL version 3.3.2+13 [15:32:52] [Render thread/INFO]: Backend library: LWJGL version 3.3.3+5

output when you use fabric:

[15:31:34] [Render thread/INFO]: Backend library: LWJGL version 3.1.2 build 29 [15:31:13] [Render thread/INFO]: Backend library: LWJGL version 3.1.6 build 14 [15:30:53] [Render thread/INFO]: Backend library: LWJGL version 3.2.1 build 12 [15:30:26] [Render thread/INFO]: Backend library: LWJGL version 3.2.2 build 10 [15:30:06] [Render thread/INFO]: Backend library: LWJGL version 3.3.1 SNAPSHOT [15:29:44] [Render thread/INFO]: Backend library: LWJGL version 3.3.2-snapshot [15:29:01] [Render thread/INFO]: Backend library: LWJGL version 3.3.3-snapshot

no changes other than the use of vanilla vs the latest fabric-loader

modmuss50 commented 2 weeks ago

What minecraft version and launcher are you using?

theofficialgman commented 2 weeks ago

What minecraft version and launcher are you using?

all versions of minecraft (tested 1.16-1.21) are affected.

all launchers are affected (tested official minecraft launcher and prism launcher)

again, this is a fabric-loader issue which is why it affects all versions and launchers

theofficialgman commented 2 weeks ago

this is a fabric-loader regression

bisected to the first incorrect version being 0.14.0. 0.13.3 and earlier do not have the issue

theofficialgman commented 2 weeks ago

likely regression causing commit https://github.com/FabricMC/fabric-loader/commit/36ed420f8d5d9b65653e1a88a424724811a3dc53

cc @sfPlayer1

sfPlayer1 commented 2 weeks ago

This comes from Version.class.getPackage().getImplementationVersion(), the class loader may not initialize all the package metadata fully at the moment. It's not particularly impactful, but will be fixed eventually..