search

FabricMC / fabric-loom

Gradle build system plugin used to automate the setup of a minecraft mod development environment.
MIT License
237 stars 201 forks source link

with layered parchment mappings, some classes don't get their method parameters mapped #1086

Open fayer3 opened 6 months ago

fayer3 commented 6 months ago

not sure if that is the same issue as #559 , but when using layered mappings with mojang + parchment the methods in some classes don't get their mapped parameters.

some I noticed are the following

from that it seems to happen with all classes that have the @DontObfuscate annotation

with just yarn, or layered with yarn they are mapped correctly with the yarn mappings

in the parchment mappings they should be mapped https://github.com/ParchmentMC/Parchment/blob/versions/1.20.x/data/com/mojang/blaze3d/platform/GlStateManager.mapping

mapping setup: 

mappings loom.layered() {
    officialMojangMappings()
    parchment("org.parchmentmc.data:parchment-1.20.4:2024.02.25@zip")
}

using loom 1.6-SNAPSHOT