search

FabricMC / fabric-loom

Gradle build system plugin used to automate the setup of a minecraft mod development environment.
MIT License
233 stars 201 forks source link

Gradle 8.4, Kotlin 1.9.10 #977

Closed JT122406 closed 10 months ago

JT122406 commented 10 months ago

Updates to Gradle 8.4 and Kotlin 1.9.10 which is the version included in 8.4

modmuss50 commented 10 months ago

Thanks for the PR, is there a need for this? Generally we only bump the gradle version when required. In 1.3 this was due to the kotlin metadata library requiring a newer Kotlin version.

When bumping the gradle version the min version should also be bumped in the bootstrap.

JT122406 commented 10 months ago

Seemed like y'all were bumping gradle with almost every new loom version

modmuss50 commented 10 months ago

Seemed like y'all were bumping gradle with almost every new loom version

Maybe we should make that rule? Usually there is a good reason to (either new features, or a forced update due to another dep).

JT122406 commented 10 months ago

Yeah lol

JT122406 commented 10 months ago

but you see what I mean