search

FabricMC / fabric-loom

Gradle build system plugin used to automate the setup of a minecraft mod development environment.
MIT License
233 stars 201 forks source link

Composite builds support for nested jars #992

Open ishland opened 9 months ago

ishland commented 9 months ago

Resolves #975

This delays dependency resolution for nested jars until it is actually needed because dependencies substituted from included builds doesn't actually resolve during configuration phase.

This also adds nestedConfigurations for RemapJar, allowing custom configurations to be used for inclusion. Note that this still retains the behavior of not adding transitive dependencies as nested jars.

modmuss50 commented 9 months ago

Thanks for adding a test, im still not super happy with this fix, but dont have a better suggestion off the top of my head. Ill have to sit down and take a better look into this.

lukebemish commented 5 months ago

This is likely superseded by #1080, which is a more idiomatic approach - storing Configuration as a task input as this PR does makes the task incompatible with configuration cache, so that would have to be changed later anyway, and my PR switches everything to use the normal configuration resolution system. I will, however, add the tests from this PR for composite builds into my PR, to ensure that using include with those continues to work.