search

FabricMC / fabric-mixin-compile-extensions

Extensions for Mixin's annotation processor.
MIT License
8 stars 8 forks source link

Mappings not resolving for Outer$Inner targets #1

Open Johni0702 opened 5 years ago

Johni0702 commented 5 years ago

Specifying a mixin target as some/package/Outer$Inner works fine in a dev env but fails to resolve any mappings for members of Inner.

@Mixin(targets = "net/minecraft/client/render/WorldRenderer$ChunkInfo")
public interface ChunkInfoAccessor {
    @Accessor("renderer")
    ChunkRenderer getChunkRenderer();
}

This works fine during dev but gives a warning when compiling and subsequently fails in prod: warning: Unable to locate obfuscation mapping for @Accessor target renderer

Specifying the target as net/minecraft/client/render/WorldRenderer/ChunkInfo properly resolves the mappings.

Not sure if that's an issue with Mixin or with the mapping provider but since it works as expected under forge, I'm posting it here.

liach commented 4 years ago

Sounds like a problem with loom gradle plugin?

modmuss50 commented 4 years ago

I should have looked here before spending hours debugging this:

I have applied a hack fix for the field desc's: https://github.com/FabricMC/fabric-mixin-compile-extensions/commit/f049573bc0ae4d50fc6fc37ea391f6f38cf429f3

Going to leave this issue open untill its really fixed.

LogicFan commented 3 years ago

https://github.com/SpongePowered/Mixin/issues/419 is closed. Do we still need this workaround?