search

FabricMC / fabric-mixin-compile-extensions

Extensions for Mixin's annotation processor.
MIT License
8 stars 8 forks source link

Mixin 0.8 preview adaption #3

Closed liach closed 4 years ago

liach commented 4 years ago

Updated the option return method and removed the mixin service (seems only used for runtime, not ap) Signed-off-by: liach liach@users.noreply.github.com

modmuss50 commented 4 years ago

In loom we will need to tweak how this is pulled in to ensure the correct one is used for the correct mixin version

modmuss50 commented 4 years ago

Looking at it, it wouldnt be too hard to support old and new, that may be a better idea.

modmuss50 commented 4 years ago

Humm, we may need a version of this PR for a branch before the v2 tiny changes for older yarn versions.

liach commented 4 years ago

This compiler extensions should be compatible with old yarn afaik as the mapping parser's tree api can load from v1 mappings.

modmuss50 commented 4 years ago

Were the changes to parser backwards compatible? as it will need to use the new parser?

liach commented 4 years ago

The new parser 0.2 did not remove anything from the parser 0.1.

modmuss50 commented 4 years ago

Ah, thats fine then. Nice work.