FabricMC / fabric

Essential hooks for modding with Fabric.
Apache License 2.0
2.32k stars 408 forks source link

FAPI .42 Broken Ores #1805

Closed itsdinkd closed 2 years ago

itsdinkd commented 2 years ago

WIth the latest Fabric API Update for 1.17.1, Industrial Ore, TechReborn Ore, Things Gleaming Ore are broken and will not allow Pickaxes to drop the ore upon breaking. Using any normally required pickaxe to break these, all it does is break the block.

If you have WTHIT Enabled, it also says the required harvested tool is a shear. Using a shear, you can get the ore content.

Vanilla ore seems in tact. only certain modded ore is broken.

image

image

Juuxel commented 2 years ago

This doesn't reproduce in a pure Fabric API test environment (where blocks are created the same way as in TR or other mods). Could you post your full mod list? I suspect some other mod is interfering here with hacky code.

itsdinkd commented 2 years ago

It's currently on my modpack. Another Quality Modpack 2 Modlist: https://pastebin.com/Dk7tZSHg

This all worked on .41 so I don't believe it to be a mod in particular.

With the last update where 0.42 was added, the following mods were updated; image

itsdinkd commented 2 years ago

Gobber dev updated his mod after I told him this, fixing his ore. They now drop ore after breaking with pickaxes. Tech Reborn, Indrev, Things ore still broken. WTHIT still shows Shears on gobber2 ore.

image

modmuss50 commented 2 years ago

I was able to reproduce this with just TR and API, the pickake still works as expected, but clearly beign able to use shears is not right.

I will update TR to the new api soon, but this still needs fixing for other mods that cannot update as quick.

itsdinkd commented 2 years ago

image image

Pick axe didn't work for me, only shears. @modmuss50

itsdinkd commented 2 years ago

Can confirm Gobber 2.4.57 caused the ore to not drop with pickaxes, regardless of Fabric API version.

Shears issue still happened though on 0.42 allowing you to break ore with shears and get its dropped content, as modmuss mentioned.

kwpugh commented 2 years ago

I got Gobber working correctly in dev, I was misunderstanding the new tags but got some help sorting it out on the Fabric discord.