FabricMC / fabric

Essential hooks for modding with Fabric.
Apache License 2.0
2.31k stars 404 forks source link

Going to resource packs then clicking done causes resource reload #3656

Open mrjasonn opened 6 months ago

mrjasonn commented 6 months ago

Going to resource packs menu then clicking done causes resource reload, but only for every time you launch the game. This has been tested on Minecraft 1.21.1 with Fabric API 0.105.0. This bug is separate from MC-264307 as I have mentioned that the issue in Fabric API is that it happens every time you launch the game.

modmuss50 commented 6 months ago

I can reproduce this in 1.20.4

haykam821 commented 6 months ago

Is this issue separate from a similar vanilla issue that also causes resource reloading when clicking the 'Done' button?

mrjasonn commented 6 months ago

Is this issue separate from a similar vanilla issue that also causes resource reloading when clicking the 'Done' button?

different from vanilla one, as [Mod] Greymagic27 said in the mojang one:

I was able to reproduce this only when I've first loaded up the game and went there. It displayed the red Mojang loading screen for 2 seconds or so.

After that I couldn't reproduce without relaunching again, and then it only did it once.

so it is separate from the Fabric API one in how it works because the Fabric API one is every time launch the game

MCLegoMan commented 5 months ago

When entering the resource pack screen, the game will disable resource packs that have been registered through fabric api, thus when pressing done it will reload the resources. If you re-enable the resources that were already enabled, the resources won't reload.

From my testing, this seems to happen no matter the activation type.

I am currently using fabric-api 0.97.3+1.20.5, with fabric loader 0.15.10, on 1.20.5-pre4, but this issue has been happening throughout the 1.20.5 snapshots.

mrjasonn commented 5 months ago

Now checked on 1.20.5, still same issue

mrjasonn commented 5 months ago

1.20.6 is also affected (API ver 0.97.8)

maevius669 commented 2 months ago

Happens with 1.21, loader 0.16.0 and fapi 0.100.7 doesnt matter if pressing "Done" or "esc", it will reload resources even if unchanged