search

FabricMC / fabric

Essential hooks for modding with Fabric.
Apache License 2.0
2.31k stars 404 forks source link

Replace redirect in lifecycle events with wrap operation #3887

Closed AlphaMode closed 1 month ago

AlphaMode commented 3 months ago

Noticed a old redirect while updating porting lib to 1.21. So I thought I might create a quick PR to fix this.

Dragon-Seeker commented 3 months ago

Seems fine

AlphaMode commented 3 months ago

Sugar could also be used here but I figured that would be just as hacky as using locals

modmuss50 commented 3 months ago

I assume there is a reason for making this change? Generally my rule in moving stuff to mixin extras is to only do it when there is actually a need/benefit or when the mixin need changing anyway (Usually during a port).

AlphaMode commented 3 months ago

I assume there is a reason for making this change? Generally my rule in moving stuff to mixin extras is to only do it when there is actually a need/benefit or when the mixin need changing anyway (Usually during a port).

I found it because it was causing a conflict in porting lib. I fixed this by just changing the injection point. Anyway there isn't really not a reason to change this as it would prevent future possible conflicts