search

FabricMC / fabric

Essential hooks for modding with Fabric.
Apache License 2.0
2.2k stars 388 forks source link

Fabric Standard Tags for Food are limited. #3899

Open Bowswa opened 4 days ago

Bowswa commented 4 days ago

As i develop both datapacks & mods more, i am realizing it is important for modded Compatibility to have different tags for golden foods & normal foods. However, the current tags are used by many mods, and removing the normal tags would cause incompatibility when updating mods.

And for people who don't need this separation, the normal tags should still exist.

Golden foods such as golden apple, enchanted golden apple, and golden carrot need too have a tag separate from the rest. and they also need to be included in the normal tag, used for targeting all fruits & vegies including golden.

I am opening a pull request myself, however as i am still new to the modding scene i'm not sure i did everything right. If this is the case, i would love to try to fix it myself, unless fabric peeps just wanna make the change thsemselves, but hopefully if i explain bad the PR should at least demonstrate what i want to happen.

Bowswa commented 4 days ago

Yes i know this does not account for mods with other golden foods such as meats or fish, nor did i PR for anything other than the 1.21 branch, but if that is something i should do i am happy to.