search

FabricMC / fabric

Essential hooks for modding with Fabric.
Apache License 2.0
2.2k stars 388 forks source link

Updating food tags to have separation of golden & non-golden foods #3900

Open Bowswa opened 4 days ago

Bowswa commented 4 days ago

Modify Standard Tags Data Generator -Structured to not break mods -Added tags for golden VS nongolden fruits & veggies -Those tags are included in the original tag as "optional".

Meant to fix #3899

TelepathicGrunt commented 1 day ago

You are missing the lang file datagen as well. And you need to run the datagenerators. Also, these new fields are not even added to ConventionalItemTags so this would not even compile. I would encourage only making edits while having the code opened in an IDE so you can run all the needed tasks, spotless, and datagenerators

TelepathicGrunt commented 1 day ago

Also, would the actual tag be

c:foods/golden_fruit c:foods/normal_fruit and then collect those two tags into c:foods/fruit

Or do c:foods/fruit/golden c:foods/fruit/golden and then collect those two tags into c:foods/fruit

Leaning towards c:foods/fruit/golden c:foods/fruit/regular and then collect those two tags into c:foods/fruit