search

FabricMC / fabric

Essential hooks for modding with Fabric.
Apache License 2.0
2.29k stars 400 forks source link

Improve data resiliency of PersistentState #3942

Open raoulvdberge opened 2 months ago

raoulvdberge commented 2 months ago

Currently, PersistentState is not safe to use because if a crash/unexpected power loss happens and there's a large PersistentState that takes a large amount of time to write to disk, it could end up only being partially written and then fail to deserialize on startup.

This has been fixed in NeoForge via following PR: https://github.com/neoforged/NeoForge/pull/1001

Refined Storage is currently having following PersistentState implementation as a stop-gap solution: https://github.com/refinedmods/refinedstorage2/blob/develop/refinedstorage-platform-common/src/main/java/com/refinedmods/refinedstorage/platform/common/support/AbstractSafeSavedData.java

modmuss50 commented 2 months ago

As discussed if we make this change it should only apply to mods, and not effect the vanilla states. How we actually determine this is not super clear to me though.