search

FabricMC / fabric

Essential hooks for modding with Fabric.
Apache License 2.0
2.29k stars 400 forks source link

Damage Type Convention Tags #4084

Open muon-rw opened 1 week ago

muon-rw commented 1 week ago

Neoforge (and previously Forge) have tag conventions for damage types not defined by vanilla which might be useful for mod compatibility.

The lack of a proper magic damage type tag is particularly problematic - many mods currently use #minecraft:witch_resistant_to, which is unintuitive and not consistently followed.

Neoforge tags: https://github.com/neoforged/NeoForge/tree/1.21.x/src/generated/resources/data/neoforge/tags/damage_type

Ideally both platforms would unify these tags into #c:is_magic, #c:is_poison, etc.

ZsoltMolnarrr commented 1 week ago

I support this, especially since the old the old Java damage type group (or whatever it was) IS_MAGIC is gone.

Would be very useful for damage type tag (filter) for my "Magic Protection" enchantment (added by my Spell Power Attributes mod).

The most functionally equivalent vanilla tag is witch_resistant_to, however it is hardly intuitive that should be used, nor does it seem sematnically correct to be referenced from every magic code related logic.