search

FabricMC / fabricmc.net

The source code and content for https://fabricmc.net/
MIT License
51 stars 28 forks source link

mod template generator forces kebab-case over snake_case for mod ids #15

Closed ix0rai closed 1 year ago

ix0rai commented 1 year ago

hey! first off, the mod template generator is amazing, great work with it! I just have one little nitpick that is the generated mod id using kebab-case over snake_case. At Quilt we encourage snake_case, and it would be fantastic if Fabric could adopt this convention too.

Technici4n commented 1 year ago

Fabric API uses kebab-case, so it will remain encouraged. Adding snake_case opt-in seems reasonable though.

modmuss50 commented 1 year ago

All of the fabric API modules use kebab case as well as mods such as fabric-language-kotlin hence why the generator follows this. The old example mod uses modid so doesnt provide a default stance on this.

However I do agree that adding an option to manually customise the modid is a good idea as it may not always want to be based of the name.

ix0rai commented 1 year ago

opt in would be great, maybe a little switch for kebab/snake case next to the id?

modmuss50 commented 1 year ago

Maybe, I was more thinking of adding an edit link to right of the modid, when clicked adds another full input to allow manually specifying the modid?

ix0rai commented 1 year ago

I like that idea, maybe with some validation so you can't press generate on something that doesn't follow snake or kebab case