FabricMC / fabricmc.net

The source code and content for https://fabricmc.net/
MIT License
51 stars 28 forks source link

Download page is broken in Firefox and Edge #7

Closed chimericdream closed 2 years ago

chimericdream commented 2 years ago

I suspect something in the recent changes is the culprit here, but nothing jumped out when I was looking at the code. There is a JS error on the page about a re-declaration of a variable (see screenshots below).

Environment: Windows 11 Firefox and Edge (Chrome seems to work)

image

image

Edit: For reference, this is the entirety of the download page. I have tried multiple browsers and both light/dark themes.

image

modmuss50 commented 2 years ago

Humm, thats very strange, I am unable to reproduce this in Chrome or Safari. Possibly worth trying a hard refresh. (Right click the refresh button with the dev tools open?)

chimericdream commented 2 years ago

I've done a hard refresh in both Edge and Firefox with no success. I'm not sure why there would be a random JS error in Firefox and Edge but not Chrome or Safari (especially since Chrome and Edge are functionally identical nowadays). But it's definitely happening.

apple502j commented 2 years ago

Could it be due to browser extensions, etc messing it up?

chimericdream commented 2 years ago

If it were just Firefox, I'd say maybe. However, I don't use Edge at all except in cases like this where I need to verify a possible bug in a website.

IMB11 commented 2 years ago

I'm on Firefox, I'll try reproduce this.

IMB11 commented 2 years ago

I'm encountering this exact same error, the button doesn't show.

IMB11 commented 2 years ago

Firefox: Dev Edition v103.0.1 Windows 10

modmuss50 commented 2 years ago

Unsure if that PR is going to help, will deploy it shortly, and then close once its confimed to fix it.

Benonardo commented 2 years ago

I'm unable to reproduce it with firefox 104.0.1 from snap on ubuntu, everything works as intended

modmuss50 commented 2 years ago

Deployed #8 Please try again and let me know if that solves your issues.

IMB11 commented 2 years ago

Seems to have solved it for me 👍

modmuss50 commented 2 years ago

Great, Thanks @JamiesWhiteShirt for figuring that out 👍

chimericdream commented 2 years ago

Confirmed working for me as well. Thanks so much!