search

FabricMC / fabricmc.net

The source code and content for https://fabricmc.net/
MIT License
51 stars 28 forks source link

Made template generator generate build.gradle with including src/main/generated #70

Closed O7410 closed 10 months ago

O7410 commented 10 months ago

issue about this: https://github.com/FabricMC/fabricmc.net/issues/69

modmuss50 commented 10 months ago

This should be handled by loom here: https://github.com/FabricMC/fabric-loom/blob/dev/1.4/src/main/java/net/fabricmc/loom/configuration/FabricApiExtension.java#L118-L121 when using configureDataGeneration()

O7410 commented 10 months ago

well it itsn't

modmuss50 commented 10 months ago

This needs fixing in loom if thats the case, let me see if I can reproduce this issue.

O7410 commented 10 months ago

steps to reproduce:

  1. download the template with these options image
  2. put something manually in src/main/generated (or generate with datagen)
  3. run the client
  4. it's not working
  5. close the game
  6. add the code to build.gradle
  7. reload gradle
  8. run the client again
  9. it's working
modmuss50 commented 10 months ago

Thanks, I have fixed this in loom. 👍