FabricMC / yarn

Libre Minecraft mappings, free to use for everyone. No exceptions.
Creative Commons Zero v1.0 Universal
927 stars 379 forks source link

SaplingGenerator is misleading #2866

Open enbrain opened 3 years ago

enbrain commented 3 years ago

It does not generate a sapling. It generates a tree when a sapling grows naturally or when a bone meal item is used on a sapling.

apple502j commented 3 years ago

True, but it also does not generate a tree (you'd modify a configure feature for that.) SaplingBehavior maybe? does it sound like pistons too much?

enbrain commented 3 years ago

SaplingBehavior maybe? does it sound like pistons too much?

I think sapling behavior is SaplingBlock itself. PistonBehavior might be an inaccurate name as well.

Maybe SaplingGrowthBehavior or TreeGrowthBehavior?

apple502j commented 3 years ago

Okay, I completely forgot PistonBehavior was just an enum :P

haykam821 commented 3 years ago

There is also CauldronBehavior, which is an interface.