Incompatible with sodium 0.5

[snoandpetals]

Describe the Bug

When Flywheel's backend is set to Instancing or Batched (this doesn't affect off), moving create blocks will not render when the scene is loaded/reloaded, however they do appear when first being placed down.

Reproduction Steps

1. Have backend set to Batched or Instancing
2. Have Sodium 5.0 installed
3. Load into a world with creations built ...

Expected Result

Blocks to appear after reloading (either closing and opening world or pressing F3 + A)

Screenshots and Videos

Crash Report or Log

No response

Operating System

Windows 10

Mod Version

0.5.1d

Minecraft Version

1.20.1

Other Mods

Create Fabric API Fabric Language Kotlin Indium (latest) Sodium (latest) Botarium Resourceful Lib Resourcefulconfig Tempad

Additional Context

No response

[wylited]

can replicate

[TropheusJ]

https://github.com/Jozufozu/Flywheel/issues/198

[cwadrupldijjit]

Out of curiosity, what is causing this issue? Any clues?

Whether or not you have an idea, I'm willing to look into it and see if it can be fixed on either the Sodium or Create sides.

[PepperCode1]

The exact cause has been known since the first day that 0.5.0 was released, so there is no need to look into it. I have not had time to add it yet, but submitting a pull request will not accelerate the addition of the fix.

[cwadrupldijjit]

What is the nature of why a PR wouldn't accelerate it? Is it because it might be more related to Flywheel than Create or Sodium? Or is it more that it's preferable that the change is not tried by a newer person? From what I can see of the other repos mentioned, you actually have a lot of experience working with the code in each of them. I'm willing to defer to your expertise in this regard.

On Thu, Aug 17, 2023 at 11:14 PM PepperCode1 @.***> wrote:

The exact cause has been known since the first day that 0.5.0 was released, so there is no need to look into it. I have not had time to add it yet, but submitting a pull request will not accelerate the addition of the fix.

— Reply to this email directly, view it on GitHub https://github.com/Fabricators-of-Create/Create/issues/1039#issuecomment-1683363537, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKN6MHKZXMASL32LHWTLNDXV323JANCNFSM6AAAAAA3FQON5U . You are receiving this because you commented.Message ID: @.***>

-- Samuel Skeen

[doonv]

Sodium 0.5.2 seems to break it completely. I only have create-fabric-0.5.1-d-build.1152+mc1.20.1, fabric-api-0.87.0+1.20.1, sodium-fabric-mc1.20.1-0.5.2, and indium-1.0.25+mc1.20.1 installed:

[zznty]

newer create builds have sodium<5.0.0 requirement so you cannot load it at all

[doonv]

newer create builds have sodium<5.0.0 requirement so you cannot load it at all

Why?

[makumaku1974]

I'm curious of what caused this bugs? I was really excited for the 1.20.1 Fabric release of Create.

[TropheusJ]

https://github.com/CaffeineMC/sodium-fabric/compare/mc1.20-0.4.10...mc1.20.1-0.5.2

[louanfontenele]

Same here, cant open Create Fabric 1.20.1 because of Sodium 0.5.2

[milkev]

Interestingly (as far as ive seen) these issues are not present if you have a shader enabled with iris. I didnt do particularly thorough testing, but in my lil custom pack i only play with shaders enabled so its fine for me.

Relevant Mod list; (can send full mod list if its considered needed) -Fabric Loader 0.14.22 -Fabric API 0.87.0 -Create 0.5.1-d-build.1161 -Sodium 0.5.2 -Sodium Extra 0.5.1 -Reeses Sodium 1.6.5-build.95 -Indium 1.0.25 -Iris 1.6.8 -Lithium 0.11.2 -Ferritecore 6.0.0 -Modernfix 5.7.1 (Dynamic textures enabled)

[makumaku1974]

Interestingly (as far as ive seen) these issues are not present if you have a shader enabled with iris. I didnt do particularly thorough testing, but in my lil custom pack i only play with shaders enabled so its fine for me.

Relevant Mod list; (can send full mod list if its considered needed) -Fabric Loader 0.14.22 -Fabric API 0.87.0 -Create 0.5.1-d-build.1161 -Sodium 0.5.2 -Sodium Extra 0.5.1 -Reeses Sodium 1.6.5-build.95 -Indium 1.0.25 -Iris 1.6.8 -Lithium 0.11.2 -Ferritecore 6.0.0 -Modernfix 5.7.1 (Dynamic textures enabled)

what shader did you used?

[milkev]

what shader did you used?

BSL

[furfy]

Can't reproduce the bug with shaders turned on too. Everything seems to be fine, didn't test it much, had to edit the mod's incompatibility list to make it work again with Sodium 0.5.* tho.

[Shadrous]

I have the same problem regardless if I have shaders on or not.

[TropheusJ]

a list of working versions can be found at #1110 this should all be fixed in the next update.

[TropheusJ]

this will be fixed with patch f