Fabricators-of-Create / Create

[Fabric Mod] Building Tools and Aesthetic Technology
MIT License
834 stars 188 forks source link

Incorrect Face Culling #1142

Closed Phoupraw closed 3 months ago

Phoupraw commented 7 months ago

Describe the Bug

Mechanical saw causes incorrect face culling.

Reproduction Steps

  1. Place a mechanical saw.
  2. Place a slab or stonecutter adjacent to the shaft face.
  3. The face of slab or stonecutter adjacent to the saw is culled.

Expected Result

The face shouldn't be culled.

Screenshots and Videos

image image

Crash Report or Log

No response

Operating System

Windows 10

Mod Version

0.5.1d

Minecraft Version

1.20.1

Other Mods

Loading 147 mods:

Additional Context

I didn't test it in forge.

Poopooracoocoo commented 7 months ago

Would you please test again with Indium 1.0.21 and Fabric API 0.88.1?

Phoupraw commented 7 months ago

Would you please test again with Indium 1.0.21 and Fabric API 0.88.1?

Incompatible mod set! net.fabricmc.loader.impl.FormattedException: Mod resolution encountered an incompatible mod set! A potential solution has been determined:

  • Replace mod 'Create' (create) 0.5.1-d-build.1161+mc1.20.1 with any version that is compatible with:
  • sodium 0.5.3 Unmet dependency listing:
  • Mod 'Create' (create) 0.5.1-d-build.1161+mc1.20.1 is incompatible with version 0.5.0 or later of mod 'Sodium' (sodium), but a matching version is present: 0.5.3!
Poopooracoocoo commented 7 months ago

What happened there?! How did you get the latest versions of those mods??

Phoupraw commented 7 months ago

What happened there?! How did you get the latest versions of those mods??

I have no idea. From modrinth.

Poopooracoocoo commented 7 months ago

Oh so you clicked the dreaded 'update all mods' button... I've always hated that...

Phoupraw commented 7 months ago

Oh so you clicked the dreaded 'update all mods' button... I've always hated that...

What's this button? I have never heard of that. We're definitely not talking about the same launcher. My launcher doesn't have this button. I download these versions manually.

Poopooracoocoo commented 7 months ago

I have no idea how you randomly updated those mods to the latest version then. :/

I'd still like you to test whether you see this with Sodium 0.4.10, Indium 1.0.21 and Fabric API 0.88.1.

Phoupraw commented 7 months ago

I have no idea how you randomly updated those mods to the latest version then. :/

I'd still like you to test whether you see this with Sodium 0.4.10, Indium 1.0.21 and Fabric API 0.88.1.

OK. I switched to these versions, successfully launched game and entered world now, and the face is still culled.

IThundxr commented 3 months ago

Try removing entity culling/more culling, also is this specific to the fabric version or does forge suffer from this aswell?

IThundxr commented 3 months ago

This affects forge aswell.

IThundxr commented 3 months ago

Upstream at https://github.com/Creators-of-Create/Create/issues/6117