search

Fabricators-of-Create / Create

[Fabric Mod] Building Tools and Aesthetic Technology
MIT License
834 stars 188 forks source link

0.5.1 Patch F Port 1.20 #1182

Closed IThundxr closed 3 months ago

AwesomeDude091 commented 6 months ago

Does this include the flywheel patch?

IThundxr commented 6 months ago

Does this include the flywheel patch?

At the moment no, however I'll be switching to IMS's flywheel branches and pulling builds from my maven until they are able to be merged into flywheel main & put on the maven

IThundxr commented 6 months ago

This PR is currently blocked as @IMS212 's flywheel fork crashes alongside sodium

Tymonoman commented 6 months ago

This PR is currently blocked as @IMS212 's flywheel fork crashes alongside sodium

Does this mean everyone is waiting for him?

IThundxr commented 6 months ago

This PR is currently blocked as @IMS212 's flywheel fork crashes alongside sodium

Does this mean everyone is waiting for him?

no its just that its one of the problems in this alongside portal trains not working at all, this PR will take a lil bit to get merged since a few bugs need ironing out

Tymonoman commented 6 months ago

This PR is currently blocked as @IMS212 's flywheel fork crashes alongside sodium

Does this mean everyone is waiting for him?

no its just that its one of the problems in this alongside portal trains not working at all, this PR will take a lil bit to get merged since a few bugs need ironing out

So how much longer you think we will be waiting for the patch that works with sodium 5.2?

IThundxr commented 6 months ago

This PR is currently blocked as @IMS212 's flywheel fork crashes alongside sodium

Does this mean everyone is waiting for him?

no its just that its one of the problems in this alongside portal trains not working at all, this PR will take a lil bit to get merged since a few bugs need ironing out

So how much longer you think we will be waiting for the patch that works with sodium 5.2?

Not sure I don't gives any ETAs

AwesomeDude091 commented 6 months ago

I assume Sodium is not patched yet?

IThundxr commented 6 months ago

I assume Sodium is not patched yet?

It is however we are waiting on pepper to make a proper flywheel fabric release and then this can be merged & any bugs left (I haven't seen any) can be fixed

AwesomeDude091 commented 6 months ago

GO Pepper :)

IThundxr commented 6 months ago

https://github.com/Jozufozu/Flywheel/pull/214 needs to be merged before this can properly be finished

IThundxr commented 4 months ago
Giovanniricotta2002 commented 4 months ago

When will the pull request be validated?

IThundxr commented 4 months ago

When will the pull request be validated?

As said multiple times, it needs the flywheel pr merged first, then needs to be tested & reviewed and then porting lib has to be bumped after the deployer crash is fixed then it can be merged & released so just be patient for now

Giovanniricotta2002 commented 4 months ago

ok

Giovanniricotta2002 commented 4 months ago

I ask the question here (since for me it is in continuity) but for the AllRecipeTypes enum it is not passed under public class like for the fan processes

IThundxr commented 4 months ago

I ask the question here (since for me it is in continuity) but for the AllRecipeTypes enum it is not passed under public class like for the fan processes

https://github.com/IThundxr-Modding/Create-Fabric/blob/mc1.20.1/fabric/dev/src/main/java/com/simibubi/create/AllRecipeTypes.java its already a public enum?

Giovanniricotta2002 commented 4 months ago

I ask the question here (since for me it is in continuity) but for the AllRecipeTypes enum it is not passed under public class like for the fan processes

https://github.com/IThundxr-Modding/Create-Fabric/blob/mc1.20.1/fabric/dev/src/main/java/com/simibubi/create/AllRecipeTypes.java its already a public enum?

I didn't know you could extend an enum, sorry for the inconvenience

unilock commented 3 months ago

Out of curiosity, why was https://github.com/IThundxr-Modding/Create-Fabric/commit/75ffe5b00797f576d3c4f2bfc088dc02ccce6788 reverted?
(Porting Lib's FakePlayer impl was replaced by Fabric API's, btw)

IThundxr commented 3 months ago

Out of curiosity, why was IThundxr-Modding@75ffe5b reverted? (Porting Lib's FakePlayer impl was replaced by Fabric API's, btw)

it uh, made every obj model fail to load, contraptions fail to render and made items using obj models to stop rendering :ioa: