Fabricators-of-Create / Create

[Fabric Mod] Building Tools and Aesthetic Technology
MIT License
834 stars 188 forks source link

Incompatible with "Show me Your Skin Mod" #1356

Closed pauliesnug closed 3 weeks ago

pauliesnug commented 2 months ago

Describe the Bug

When using a Copper/Netherite back tank with the Show Me Your Skin! mod, the opacity settings do not affect the visibility of the armor.

This bug was reported on the Show Me Your Skin! GitHub repository here: https://github.com/enjarai/show-me-your-skin/issues/47, but the author said that it was not an issue on their side and that Create armour bypassed traditional Fabric APIs.

Reproduction Steps

  1. Install Create Forge/Fabric on any version since custom Create armour was introduced
  2. Install the Show Me Your Skin! mod
  3. Try to adjust the opacity of the armour and of vanilla armour, the vanilla armour will work, the Create armour will not

Expected Result

I expected the opacity of my custom create armour to change with the settings.

Screenshots and Videos

No response

Crash Report or Log

No response

Operating System

MacOS Sonoma 14

Mod Version

0.5.1d

Minecraft Version

1.20.1

Other Mods

I was using Create Fabric Sodium Patch rather than normal Create Fabric, but it is still patch D, even on non-Sodium Patch because patch F and E have not been released.

Additional Context

No response

IThundxr commented 2 months ago

Can you reproduce this with official create? We don't support unofficial forks here

pauliesnug commented 2 months ago

@IThundxr yes, i will test it with patch F ASAP, thank you for your quick response

FeeeeK commented 3 weeks ago

Issue still persists on the latest versions of both mods

IThundxr commented 3 weeks ago

not a issue on our side, Show me your skin has to fix this in their side