Fabricators-of-Create / Create

[Fabric Mod] Building Tools and Aesthetic Technology
MIT License
834 stars 188 forks source link

Still crashing with Mixer recipe tooltip #1382

Closed Ricket closed 2 months ago

Ricket commented 2 months ago

Describe the Bug

c2ecbf797a5282124bf68a4b6dd6818b98ae1e9e attempted to fix a crash with hovering over an item while on Mixer recipe page. But, the crash still occurs.

outputIndex > results.size() should instead be outputIndex >= results.size() . When I make that fix and compile & test, the crash no longer happens.

Reproduction Steps

  1. I'm using modpack StaTech Industries, pack version 1.1.12. I built Create from the current head of 1.19/fabric/dev branch, i.e. 6b6bd608b87b6fca45c773e448b5032f36340189 .
  2. Look up the recipe for Bronze Ingot (Modern Industrialization).
  3. Go to the Mixer tab
  4. Hover the Raw Tin ingredient
  5. Client immediately crashes.

Expected Result

No crash

Screenshots and Videos

No response

Crash Report or Log

No response

Operating System

Windows 11

Mod Version

0.5.1f

Minecraft Version

1.19.2

Other Mods

modpack: StaTech Industries, pack version 1.1.12.

Additional Context

No response