Fabricators-of-Create / Create

[Fabric Mod] Building Tools and Aesthetic Technology
MIT License
834 stars 188 forks source link

Wrong chance number being shown on some recipes #1393

Closed Abalieno closed 1 month ago

Abalieno commented 1 month ago

Describe the Bug

{ "type": "create:splashing", "ingredients": [ { "item": "minecraft:gravel" } ], "results": [ { "item": "geggy:gravel_dust" }, { "chance": 0.25, "item": "minecraft:flint" }, { "chance": 0.125, "item": "magick:calcite_dust" }, { "chance": 0.09, "count": 3, "item": "geghilarity:tiny_rock_salt_dust" } ] }

Using create-fabric-0.5.1-f-build.1365+mc1.19.2

the tooltips chances in REI are all misplaced.

The gravel block ingredients shows 25% chance. It's not even an output. Gravel dust output shows a 12% chance, when it's 100%, no chance used. Flint shows a 9% chance, that should be on rock salt. Both calcite and rock salt instead show no chance field on the tooltip, despite having a chance in the recipe.

Essentially it appends the chance on the input, and then distributes the rest all wrong from there.

Without opening a different issue, also reporting that ingredients used in all sequenced assemblies, for example items used in deployers, still aren't indexed, so you can look up "uses" of an item, if that item is used on sequenced assemblies (it only tracks it if it's the first item that starts the sequence).

Reproduction Steps

Above

Expected Result

REI not bugged to hell and back

Screenshots and Videos

tuiou;

Crash Report or Log

No response

Operating System

Windows 10

Mod Version

0.5.1f

Minecraft Version

1.19.2

Other Mods

No response

Additional Context

No response