Fabricators-of-Create / Create

[Fabric Mod] Building Tools and Aesthetic Technology
MIT License
834 stars 188 forks source link

Music discs exploit #1403

Closed anatoliigorin closed 4 weeks ago

anatoliigorin commented 1 month ago

Describe the Bug

When I throw one music disc into the chute, an infinite number of music discs fall out of the jukebox

Reproduction Steps

  1. Place chute on the jukebox
  2. Throw any music disk into the chute
  3. And now there's one music disc in the jukebox, and one music disc in the chute.
  4. If you take the music discs out of the jukebox, they will multiply endlessly

Expected Result

One music disc IN - one music disc OUT

Screenshots and Videos

2024-03-28_20 05 24

Crash Report or Log

No response

Operating System

Windows 10

Mod Version

0.5.1f

Minecraft Version

1.20.1

Other Mods

fabric-api-0.92.0+1.20.1 only

Additional Context

No response

IThundxr commented 1 month ago

Please check if this occurs on forge aswell, if it does then this issue should be made on the forge repo instead

anatoliigorin commented 1 month ago

Please check if this occurs on forge aswell, if it does then this issue should be made on the forge repo instead

On the forge version, the music disc does not fall from the chute into the jukebox, but remains in the chute

IThundxr commented 1 month ago

Alright thanks, I'll take a look soon

TropheusJ commented 1 month ago

This is a bug in Fabric API. there is nothing we can do about it. https://github.com/FabricMC/fabric/issues/3680

Syst3ms commented 1 month ago

This bug has been fixed in FAPI in the latest version.

IThundxr commented 1 month ago

This bug has been fixed in FAPI in the latest version.

Once QFAPI updates to this aswell this can be closed.

TropheusJ commented 4 weeks ago

it'll update eventually, we can close this