search

Fabricators-of-Create / Create

[Fabric Mod] Building Tools and Aesthetic Technology
MIT License
827 stars 185 forks source link

Incompatible with Sound Physics Remastered after v0.5.1f Patch 1 update #1432

Closed IJuanTM closed 3 weeks ago

IJuanTM commented 3 weeks ago

Describe the Bug

Since version v0.5.1f Patch 1 (I think) Create is no longer compatible with Sound Physics Remastered as reported by the Fabric Loader (1.15.9).

It was working fine a couple of days ago, so I assume this is a unexpected by-product of the latest update.

Reproduction Steps

  1. Create a mod pack using Fabric Loader 1.15.9
  2. Install version 1.3.1 of the Sound Physics Remastered mod
  3. Install version v0.5.1f Patch 1 of the Create mod
  4. Try to start the game and you should get the error.

Expected Result

Game should start normally without error.

Screenshots and Videos

Screenshot 2024-04-08 165038

Crash Report or Log

No response

Operating System

Windows 10

Mod Version

0.5.1f

Minecraft Version

1.20.1

Other Mods

Additional Context

No response

IThundxr commented 3 weeks ago

Intended as per the changelog see https://github.com/henkelmax/sound-physics-remastered/issues/172

Killercrab432 commented 3 weeks ago

a toggle to turn off this forced incompatibility would be great, seems pretty overkill to remove all functionality between the mods due to an issue that does not seem that game breaking (correct me if im wrong)

PepperCode1 commented 3 weeks ago

The issue is that the game crashes, which is most definitely a game breaking issue.

DarianLStephens commented 3 weeks ago

From the looks of related issues, it seems that this has been known for a while, causes lots of visual issues, and people keep reporting it over and over. They probably added it to the forced incompatibility list to stop these issues and maybe encourage the Sound Physics Remastered dev(s) to finally resolve the problem.

IJuanTM commented 3 weeks ago

Intended as per the changelog see henkelmax/sound-physics-remastered#172

Ah alright thanks, I missed this post as it is older than the timeframe I was searching in, thought it might have been a newer issue as I was using the two mods together until a couple days ago.

IJuanTM commented 3 weeks ago

The issue is that the game crashes, which is most definitely a game breaking issue.

I have been using the two mods together for a couple of months and never had a crash, maybe I was lucky or something?

NolanHewitt commented 3 weeks ago

It only happens sometimes. If you're lucky you wont run into issues. Seems to be very dependent on hardware.

User4716 commented 3 weeks ago

So the developer of soundphysics has to fix this, and the developer of create fabric won't fix this?

TropheusJ commented 3 weeks ago

We cant fix it.

JanLukasGithub commented 3 weeks ago

Welp you could fix it for them (if that mod is open source), but I get why that's not the way to do it. There is probably no good way on Creates side to have a kind of "Proceed with risks" option instead of the complete incompatibility right? That would allow for people to continue using the mods together if they never had problems before, if it is possible?

IThundxr commented 3 weeks ago

Welp you could fix it for them (if that mod is open source), but I get why that's not the way to do it. There is probably no good way on Creates side to have a kind of "Proceed with risks" option instead of the complete incompatibility right? That would allow for people to continue using the mods together if they never had problems before, if it is possible?

Fabric already supports that, it's called fabric loader overrides. The dev has reopened the issue and is probably having a look at ways to fix it.

augustsaintfreytag commented 6 days ago

Just to keep the Create community in the loop, I spent some days on developing a fix to the issues with Sound Physics Remastered and wrote a working proof of concept. You can find my comment here: https://github.com/henkelmax/sound-physics-remastered/issues/172#issuecomment-2080549494