search

Fabricators-of-Create / Create

[Fabric Mod] Building Tools and Aesthetic Technology
MIT License
855 stars 195 forks source link

Threshold switches read basins improperly #1484

Open squimbo opened 2 months ago

squimbo commented 2 months ago

Describe the Bug

Threshold switches seem to read 1000mb of fluid as ~5% and a stack of items as ~18%

Reproduction Steps

  1. Place threshold switch facing basin
  2. Deposit items or liquids into the basin
  3. Look at threshold switch with confusion

Expected Result

When filtered, a threshold switch should show the current vs max possible amount of the material present in the basin (64 for items, 1000mb for fluids) Given that they can take multiple different kinds of material, I'm not sure what an unfiltered stockpile switch should do.

Screenshots and Videos

No response

Crash Report or Log

No response

Operating System

Windows 10

Mod Version

0.5.1f

Minecraft Version

1.20.1

Other Mods

    amendments: Amendments 1.20-1.1.27
        mixinsquared: MixinSquared 0.1.1
    antique-atlas: Antique Atlas 1.4.3+1.20
        folk_sisby_kaleido-config: kaleido-config 0.1.1+1.1.0-beta.3
    appleskin: AppleSkin 2.5.1+mc1.20
    architectury: Architectury 9.2.14
    armorstatues: Armor Statues 8.0.5
    bbs: Better Block Sounds 1.20.1-0.1.3
    betterchunkloading: Better chunk loading mod 1.20.1-4.2
    betterfpsdist: Better FPS distance Mod 1.20.1-4.3
    biomeparticleweather: BiomeParticleWeather 5.2.2
    blockrunner: Block Runner 8.0.4
    bookshelf: Bookshelf 20.1.10
    charmofundying: Charm of Undying 6.5.0+1.20.1
        spectrelib: SpectreLib 0.13.15+1.20.1
    chunksending: Chunksending Mod 1.20.1-2.8
    chunky: Chunky 1.3.146
    cicada: CICADA 0.7.1+1.20.1
    clickadv: Clickable Advancements Mod 1.20.1-3.8
    cloth-config: Cloth Config v11 11.1.118
        cloth-basic-math: cloth-basic-math 0.6.1
    clumps: Clumps 12.0.0.4
    collective: Collective 7.56
    combatnouveau: Combat Nouveau 8.0.5
        reach-entity-attributes: Reach Entity Attributes 2.4.0
    comforts: Comforts 6.3.5+1.20.1
    completionistsindex: Completionist's Index 8.0.0
    continents: Continents 1.1.4
    controlling: Controlling For Fabric 12.0.2
    copycats: Create: Copycats+ 1.20.1-1.2.6
    create: Create 0.5.1-f-build.1417+mc1.20.1
        com_electronwill_night-config_core: core 3.6.6
        com_electronwill_night-config_toml: toml 3.6.6
        com_google_code_findbugs_jsr305: jsr305 3.0.2
        flywheel: Flywheel 0.6.10-2
        milk: Milk Lib 1.2.60
            dripstone_fluid_lib: Dripstone Fluid Lib 3.0.2
        porting_lib_brewing: Porting Lib Brewing 2.3.2+1.20.1
        porting_lib_models: Porting Lib Models 2.3.2+1.20.1
        porting_lib_obj_loader: Porting Lib Obj Loader 2.3.2+1.20.1
            porting_lib_model_loader: Porting Lib Model Loader 2.3.2+1.20.1
        porting_lib_tags: Porting Lib Tags 3.0
        registrate-fabric: Registrate for Fabric 1.3.62-MC1.20.1
            porting_lib_data: Porting Lib Data 2.1.1090+1.20
            porting_lib_model_generators: Porting Lib Model Generators 2.1.1090+1.20
                porting_lib_gametest: Porting Lib GameTest 2.1.1090+1.20
                porting_lib_model_materials: Porting Lib Model Materials 2.1.1090+1.20
    create_copper_and_zinc: Create: Copper & Zinc Renewables 1.4.0
    create_enchantment_industry: Create Enchantment Industry 1.2.16
        create_dragon_lib: Create Dragon Lib 1.4.2
    create_jetpack: Create Jetpack 4.2.0
        flightlib: Flight Lib 2.1.0
    create_power_loader: Create: Power Loader 1.4.3-mc1.20.1-fabric
        porting_lib_chunk_loading: Porting Lib Chunk Loading 2.3.0+1.20.1
    cupboard: cupboard 1.20.1-2.6
    cutthrough: Cut Through 8.0.2
    doubledoors: Double Doors 5.5
    dynamictrim: DynamicTrim 1.4.1
    easyanvils: Easy Anvils 8.0.2
    easymagic: Easy Magic 8.0.1
    easyshulkerboxes: Easy Shulker Boxes 8.0.2
        puzzlesapi: Puzzles Api 8.1.6
            cardinal-components-base: Cardinal Components API (base) 5.2.2
            cardinal-components-entity: Cardinal Components API (entities) 5.2.2
            puzzlesaccessapi: Puzzles Access Api 8.0.9
    effectdescriptions: Effect Descriptions 8.0.2
    elytraslot: Elytra Slot 6.3.0+1.20.1
    embeddium: Embeddium 0.3.17+mc1.20.1
        indium: Indium 1.99.99
        sodium: Sodium 0.5.8
    enchdesc: EnchantmentDescriptions 17.0.14
    entityculling: EntityCulling-Fabric 1.6.2-mc1.20.1
    expandedstorage: Expanded Storage 10.1.5
    fabric-api: Fabric API 0.92.1+1.20.1
        fabric-api-base: Fabric API Base 0.4.31+1802ada577
        fabric-api-lookup-api-v1: Fabric API Lookup API (v1) 1.6.36+1802ada577
        fabric-biome-api-v1: Fabric Biome API (v1) 13.0.13+1802ada577
        fabric-block-api-v1: Fabric Block API (v1) 1.0.11+1802ada577
        fabric-block-view-api-v2: Fabric BlockView API (v2) 1.0.1+1802ada577
        fabric-blockrenderlayer-v1: Fabric BlockRenderLayer Registration (v1) 1.1.41+1802ada577
        fabric-client-tags-api-v1: Fabric Client Tags 1.1.2+1802ada577
        fabric-command-api-v1: Fabric Command API (v1) 1.2.34+f71b366f77
        fabric-command-api-v2: Fabric Command API (v2) 2.2.13+1802ada577
        fabric-commands-v0: Fabric Commands (v0) 0.2.51+df3654b377
        fabric-containers-v0: Fabric Containers (v0) 0.1.64+df3654b377
        fabric-content-registries-v0: Fabric Content Registries (v0) 4.0.11+1802ada577
        fabric-convention-tags-v1: Fabric Convention Tags 1.5.5+1802ada577
        fabric-crash-report-info-v1: Fabric Crash Report Info (v1) 0.2.19+1802ada577
        fabric-data-attachment-api-v1: Fabric Data Attachment API (v1) 1.0.0+de0fd6d177
        fabric-data-generation-api-v1: Fabric Data Generation API (v1) 12.3.4+1802ada577
        fabric-dimensions-v1: Fabric Dimensions API (v1) 2.1.54+1802ada577
        fabric-entity-events-v1: Fabric Entity Events (v1) 1.6.0+1c78457f77
        fabric-events-interaction-v0: Fabric Events Interaction (v0) 0.6.2+1802ada577
        fabric-events-lifecycle-v0: Fabric Events Lifecycle (v0) 0.2.63+df3654b377
        fabric-game-rule-api-v1: Fabric Game Rule API (v1) 1.0.40+1802ada577
        fabric-item-api-v1: Fabric Item API (v1) 2.1.28+1802ada577
        fabric-item-group-api-v1: Fabric Item Group API (v1) 4.0.12+1802ada577
        fabric-key-binding-api-v1: Fabric Key Binding API (v1) 1.0.37+1802ada577
        fabric-keybindings-v0: Fabric Key Bindings (v0) 0.2.35+df3654b377
        fabric-lifecycle-events-v1: Fabric Lifecycle Events (v1) 2.2.22+1802ada577
        fabric-loot-api-v2: Fabric Loot API (v2) 1.2.1+1802ada577
        fabric-loot-tables-v1: Fabric Loot Tables (v1) 1.1.45+9e7660c677
        fabric-message-api-v1: Fabric Message API (v1) 5.1.9+1802ada577
        fabric-mining-level-api-v1: Fabric Mining Level API (v1) 2.1.50+1802ada577
        fabric-model-loading-api-v1: Fabric Model Loading API (v1) 1.0.3+1802ada577
        fabric-models-v0: Fabric Models (v0) 0.4.2+9386d8a777
        fabric-networking-api-v1: Fabric Networking API (v1) 1.3.11+1802ada577
        fabric-networking-v0: Fabric Networking (v0) 0.3.51+df3654b377
        fabric-object-builder-api-v1: Fabric Object Builder API (v1) 11.1.3+1802ada577
        fabric-particles-v1: Fabric Particles (v1) 1.1.2+1802ada577
        fabric-recipe-api-v1: Fabric Recipe API (v1) 1.0.21+1802ada577
        fabric-registry-sync-v0: Fabric Registry Sync (v0) 2.3.3+1802ada577
        fabric-renderer-api-v1: Fabric Renderer API (v1) 3.2.1+1802ada577
        fabric-renderer-indigo: Fabric Renderer - Indigo 1.5.1+1802ada577
        fabric-renderer-registries-v1: Fabric Renderer Registries (v1) 3.2.46+df3654b377
        fabric-rendering-data-attachment-v1: Fabric Rendering Data Attachment (v1) 0.3.37+92a0d36777
        fabric-rendering-fluids-v1: Fabric Rendering Fluids (v1) 3.0.28+1802ada577
        fabric-rendering-v0: Fabric Rendering (v0) 1.1.49+df3654b377
        fabric-rendering-v1: Fabric Rendering (v1) 3.0.8+1802ada577
        fabric-resource-conditions-api-v1: Fabric Resource Conditions API (v1) 2.3.8+1802ada577
        fabric-resource-loader-v0: Fabric Resource Loader (v0) 0.11.10+1802ada577
        fabric-screen-api-v1: Fabric Screen API (v1) 2.0.8+1802ada577
        fabric-screen-handler-api-v1: Fabric Screen Handler API (v1) 1.3.30+1802ada577
        fabric-sound-api-v1: Fabric Sound API (v1) 1.0.13+1802ada577
        fabric-transfer-api-v1: Fabric Transfer API (v1) 3.3.5+8dd72ea377
        fabric-transitive-access-wideners-v1: Fabric Transitive Access Wideners (v1) 4.3.1+1802ada577
    fabric-language-kotlin: Fabric Language Kotlin 1.10.19+kotlin.1.9.23
        org_jetbrains_kotlin_kotlin-reflect: kotlin-reflect 1.9.23
        org_jetbrains_kotlin_kotlin-stdlib: kotlin-stdlib 1.9.23
        org_jetbrains_kotlin_kotlin-stdlib-jdk7: kotlin-stdlib-jdk7 1.9.23
        org_jetbrains_kotlin_kotlin-stdlib-jdk8: kotlin-stdlib-jdk8 1.9.23
        org_jetbrains_kotlinx_atomicfu-jvm: atomicfu-jvm 0.23.2
        org_jetbrains_kotlinx_kotlinx-coroutines-core-jvm: kotlinx-coroutines-core-jvm 1.8.0
        org_jetbrains_kotlinx_kotlinx-coroutines-jdk8: kotlinx-coroutines-jdk8 1.8.0
        org_jetbrains_kotlinx_kotlinx-datetime-jvm: kotlinx-datetime-jvm 0.5.0
        org_jetbrains_kotlinx_kotlinx-serialization-cbor-jvm: kotlinx-serialization-cbor-jvm 1.6.3
        org_jetbrains_kotlinx_kotlinx-serialization-core-jvm: kotlinx-serialization-core-jvm 1.6.3
        org_jetbrains_kotlinx_kotlinx-serialization-json-jvm: kotlinx-serialization-json-jvm 1.6.3
    fabricloader: Fabric Loader 0.15.11
        mixinextras: MixinExtras 0.3.5
    farmersdelight: Farmer's Delight 1.20.1-2.1.1+refabricated
        mm: Manningham Mills 2.3
        porting_lib_accessors: Porting Lib Accessors 2.3.4+1.20.1
        porting_lib_base: Porting Lib Base 2.3.4+1.20.1
            porting_lib_attributes: Porting Lib Attributes 2.3.4+1.20.1
            porting_lib_common: Porting Lib Common 2.3.4+1.20.1
            porting_lib_entity: Porting Lib Entity 2.3.4+1.20.1
            porting_lib_fluids: Porting Lib Fluids 2.3.4+1.20.1
            porting_lib_mixin_extensions: Porting Lib Mixin Extensions 2.3.4+1.20.1
            porting_lib_transfer: Porting Lib Transfer 2.3.4+1.20.1
            porting_lib_utility: Porting Lib Utility 2.3.4+1.20.1
        porting_lib_client_events: Porting Lib Client Events 2.3.4+1.20.1
            porting_lib_core: Porting Lib Core 2.3.4+1.20.1
        porting_lib_config: Porting Lib Config 2.3.4+1.20.1
        porting_lib_extensions: Porting Lib Extensions 2.3.4+1.20.1
        porting_lib_lazy_registration: Porting Lib Lazy Register 2.3.4+1.20.1
        porting_lib_loot: Porting Lib Loot 2.3.4+1.20.1
        porting_lib_networking: Porting Lib Networking 2.3.4+1.20.1
        porting_lib_recipe_book_categories: Porting Lib Recipe Book Categories 2.3.4+1.20.1
        porting_lib_registries: Porting Lib Registries 2.3.4+1.20.1
        porting_lib_tool_actions: Porting Lib Tool Actions 2.3.4+1.20.1
    farsight: Farsight Mod 1.20.1-4.2
        org_jctools_jctools-core: jctools-core 4.0.1
    fastasyncworldsave: fastasyncworldsave Mod 1.20.1-1.9
    ferritecore: FerriteCore 6.0.1
    figura: Figura 0.1.4+1.20.1
        com_github_figuramc_luaj_luaj-core: luaj-core 3.0.8-figura
        com_github_figuramc_luaj_luaj-jse: luaj-jse 3.0.8-figura
        com_neovisionaries_nv-websocket-client: nv-websocket-client 2.14
    forgeconfigapiport: Forge Config API Port 8.0.0
    fusion: Fusion 1.1.1
    globalpacks: Global Data- & Resourcepacks 1.16.1_fabric
    gpumemleakfix: Gpu memory leak fix mod 1.20.1-1.8
    guicompass: GUI Compass 4.6
    handcrafted: Handcrafted 3.0.6
    harvestwithease: Harvest with ease 8.0.1.0
    inmis: Inmis 2.7.2-1.20.1
        omega-config: OmegaConfig 1.2.3-1.18.1
    inmisaddon: InmisAddon 1.0.4
    iris: Iris 1.6.17
        io_github_douira_glsl-transformer: glsl-transformer 2.0.0-pre13
        org_anarres_jcpp: jcpp 1.4.14
        org_antlr_antlr4-runtime: antlr4-runtime 4.11.1
    irisflw: Iris Flywheel Compat 0.2.4
    jade: Jade 11.8.0
    jamlib: JamLib 0.6.1+1.20.x
    java: OpenJDK 64-Bit Server VM 17
    jeed: Just Enough Effects Descriptions 1.20-2.1.12
    jei: Just Enough Items 15.3.0.4
    jeresources: Just Enough Resources 1.4.0.247
    jump_sounds: Jump Sounds 1.4.3
    justenoughprofessions: Just Enough Professions (JEP) 3.0.1
    leavesbegone: Leaves Be Gone 8.0.0
    memorysettings: Memorysettings Mod 1.20.1-5.3
    minecraft: Minecraft 1.20.1
    modernfix: ModernFix 5.17.0+mc1.20.1
    moonlight: Moonlight 1.20-2.11.17
    mousetweaks: Mouse Tweaks 2.26
    mru: Mineblock's Repeated Utilities 0.4.0+1.20
    naturescompass: Nature's Compass 1.20.1-2.2.3-fabric
    njb: Not Just Biomes 1.1.0
    notenoughanimations: NotEnoughAnimations 1.7.3
    polymorph: Polymorph 0.49.3+1.20.1
        cardinal-components-block: Cardinal Components API (blocks) 5.2.1
        cardinal-components-item: Cardinal Components API (items) 5.2.1
    portallinkingcompass: Portal Linking Compass 1.0.1+mc1.20
    puzzleslib: Puzzles Lib 8.1.18
    railways: Create: Steam 'n' Rails 1.6.3+fabric-mc1.20.1
    rechiseled: Rechiseled 1.1.6
    rechiseledcreate: Rechiseled: Create 1.0.2+a
    recipeessentials: recipeessentials Mod 1.20.1-3.4
    resourcefullib: Resourceful Lib 2.1.24
        com_teamresourceful_bytecodecs: bytecodecs 1.0.2
        com_teamresourceful_yabn: yabn 1.0.3
    searchables: Searchables 1.0.3
    showmeyourskin: Show Me Your Skin! 1.9.0+1.20
    simplebackup: simplebackup 2.0-1.20
        com_github_spoorn_tar-lz4-java: tar-lz4-java 1.0.3
        net_lingala_zip4j_zip4j: zip4j 2.11.5
    smallships: Small Ships 2.0.0-b1.1
    smoothchunk: Smooth chunk save Mod 1.20.1-3.6
    sounds: Sounds 0.7.0+1.20.1
        yet_another_config_lib_v3: YetAnotherConfigLib 3.2.2+1.20
            com_twelvemonkeys_common_common-image: common-image 3.10.0-SNAPSHOT
            com_twelvemonkeys_common_common-io: common-io 3.10.0-SNAPSHOT
            com_twelvemonkeys_common_common-lang: common-lang 3.10.0-SNAPSHOT
            com_twelvemonkeys_imageio_imageio-core: imageio-core 3.10.0-SNAPSHOT
            com_twelvemonkeys_imageio_imageio-metadata: imageio-metadata 3.10.0-SNAPSHOT
            com_twelvemonkeys_imageio_imageio-webp: imageio-webp 3.10.0-SNAPSHOT
            org_quiltmc_parsers_gson: gson 0.2.1
            org_quiltmc_parsers_json: json 0.2.1
    strawstatues: Straw Statues 8.0.3
    structureessentials: Structure Essentials Mod 1.20.1-3.3
    supermartijn642configlib: SuperMartijn642's Config Lib 1.1.8+a
    supermartijn642corelib: SuperMartijn642's Core Lib 1.1.17
    supplementaries: Supplementaries 1.20-2.8.10
    toms_storage: Tom's Simple Storage Mod 1.6.6
    trinkets: Trinkets 3.7.2
    trowel: Trowel 1.2.1@1.20
    visualworkbench: Visual Workbench 8.0.0
    xercapaint: Joy of Painting fabric-1.20.1-1.0.0
    yigd: You're in Grave Danger 2.0.0-beta.11
        fabric-permissions-api-v0: fabric-permissions-api 0.2-SNAPSHOT
        libgui: LibGui 8.1.1+1.20.1
            jankson: Jankson 6.0.0+j1.2.3
                blue_endless_jankson: jankson 1.2.3
            libninepatch: LibNinePatch 1.2.0

Additional Context

No response

MrStickyPiston commented 2 months ago

May or may not be in relation to https://github.com/Fabricators-of-Create/Create/issues/1459