Fabricators-of-Create / Create

[Fabric Mod] Building Tools and Aesthetic Technology
MIT License
894 stars 200 forks source link

Cannot interact with Valve Handles in Adventure Mode #1594

Open Narotiza opened 2 months ago

Narotiza commented 2 months ago

Description

In adventure mode, it is impossible to interact with valve handles in any way. Looking at one causes the rotation angle to appear (with 4 white pixels around the number that don't seem to appear in any other context), but they cannot be rotated forwards, backwards, or have their angle changed by long-right-clicking.

Expected behavior is that, in adventure mode, valve handles can be turned in either direction like in Survival or Creative, but cannot have their rotation angle & direction changed (nor should the angle text appear as if it can be)

This is different from this issue on the Forge version, because in that one the valve can still be rotated, but not backwards, while the angle and direction can be changed.

i would like this fixed because i am working on a custom map in adventure mode that uses Create, and the ability for valves to be used (but not modified) is crucial for several puzzles.

image image

Game Log

https://mclo.gs/fhMTJsK

Debug Information

Client Info ``` Create: Mod Version: 0.5.1f Fabric API Version: 0.92.2+1.20.1 Minecraft Version: 1.20.1 Graphics: Flywheel Version: 0.6.10-2 Flywheel Backend: INSTANCING OpenGL Renderer: NVIDIA GeForce RTX 3060 Laptop GPU/PCIe/SSE2 OpenGL Version: 3.2.0 NVIDIA 546.65 Graphics Mode: Graphics System Information: Operating System: Windows 10 (amd64) version 10.0 Java Version: 18-beta, Eclipse Adoptium JVM Flags: 3 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xms512m -Xmx4096m Memory: 565367296 bytes (539 MiB) / 1990197248 bytes (1898 MiB) up to 4294967296 bytes (4096 MiB) CPU: AMD Ryzen 7 5800H with Radeon Graphics @ 3.19 GHz; 8 cores / 16 threads on 1 socket(s) Graphics card #0: NVIDIA GeForce RTX 3060 Laptop GPU (NVIDIA (0x10de)); 4095.00 MB of VRAM Other Mods: core: 3.6.6 toml: 3.6.6 jsr305: 3.0.2 Dripstone Fluid Lib: 3.0.2 Fabric API Base: 0.4.31+1802ada577 Fabric API Lookup API (v1): 1.6.36+1802ada577 Fabric Biome API (v1): 13.0.13+1802ada577 Fabric Block API (v1): 1.0.11+1802ada577 Fabric BlockView API (v2): 1.0.1+1802ada577 Fabric BlockRenderLayer Registration (v1): 1.1.41+1802ada577 Fabric Client Tags: 1.1.2+1802ada577 Fabric Command API (v1): 1.2.34+f71b366f77 Fabric Command API (v2): 2.2.13+1802ada577 Fabric Commands (v0): 0.2.51+df3654b377 Fabric Containers (v0): 0.1.64+df3654b377 Fabric Content Registries (v0): 4.0.11+1802ada577 Fabric Convention Tags: 1.5.5+1802ada577 Fabric Crash Report Info (v1): 0.2.19+1802ada577 Fabric Data Attachment API (v1): 1.0.0+de0fd6d177 Fabric Data Generation API (v1): 12.3.4+1802ada577 Fabric Dimensions API (v1): 2.1.54+1802ada577 Fabric Entity Events (v1): 1.6.0+1c78457f77 Fabric Events Interaction (v0): 0.6.2+1802ada577 Fabric Events Lifecycle (v0): 0.2.63+df3654b377 Fabric Game Rule API (v1): 1.0.40+1802ada577 Fabric Item API (v1): 2.1.28+1802ada577 Fabric Item Group API (v1): 4.0.12+1802ada577 Fabric Key Binding API (v1): 1.0.37+1802ada577 Fabric Key Bindings (v0): 0.2.35+df3654b377 Fabric Lifecycle Events (v1): 2.2.22+1802ada577 Fabric Loot API (v2): 1.2.1+1802ada577 Fabric Loot Tables (v1): 1.1.45+9e7660c677 Fabric Message API (v1): 5.1.9+1802ada577 Fabric Mining Level API (v1): 2.1.50+1802ada577 Fabric Model Loading API (v1): 1.0.3+1802ada577 Fabric Models (v0): 0.4.2+9386d8a777 Fabric Networking API (v1): 1.3.11+1802ada577 Fabric Networking (v0): 0.3.51+df3654b377 Fabric Object Builder API (v1): 11.1.3+1802ada577 Fabric Particles (v1): 1.1.2+1802ada577 Fabric Recipe API (v1): 1.0.21+1802ada577 Fabric Registry Sync (v0): 2.3.3+1802ada577 Fabric Renderer API (v1): 3.2.1+1802ada577 Fabric Renderer - Indigo: 1.5.2+85287f9f77 Fabric Renderer Registries (v1): 3.2.46+df3654b377 Fabric Rendering Data Attachment (v1): 0.3.37+92a0d36777 Fabric Rendering Fluids (v1): 3.0.28+1802ada577 Fabric Rendering (v0): 1.1.49+df3654b377 Fabric Rendering (v1): 3.0.8+1802ada577 Fabric Resource Conditions API (v1): 2.3.8+1802ada577 Fabric Resource Loader (v0): 0.11.10+1802ada577 Fabric Screen API (v1): 2.0.8+1802ada577 Fabric Screen Handler API (v1): 1.3.30+1802ada577 Fabric Sound API (v1): 1.0.13+1802ada577 Fabric Transfer API (v1): 3.3.5+8dd72ea377 Fabric Transitive Access Wideners (v1): 4.3.1+1802ada577 Fabric Loader: 0.16.3 Forge Config API Port: 8.0.0 OpenJDK 64-Bit Server VM: 18 Milk Lib: 1.2.60 MixinExtras: 0.4.1 Porting Lib Accessors: 2.3.2+1.20.1 Porting Lib Attributes: 2.3.2+1.20.1 Porting Lib Base: 2.3.2+1.20.1 Porting Lib Brewing: 2.3.2+1.20.1 Porting Lib Client Events: 2.3.2+1.20.1 Porting Lib Common: 2.3.2+1.20.1 Porting Lib Config: 2.3.2+1.20.1 Porting Lib Core: 2.3.2+1.20.1 Porting Lib Data: 2.1.1090+1.20 Porting Lib Entity: 2.3.2+1.20.1 Porting Lib Extensions: 2.3.2+1.20.1 Porting Lib Fluids: 2.3.2+1.20.1 Porting Lib GameTest: 2.1.1090+1.20 Porting Lib Lazy Register: 2.3.2+1.20.1 Porting Lib Mixin Extensions: 2.3.2+1.20.1 Porting Lib Model Generators: 2.1.1090+1.20 Porting Lib Model Loader: 2.3.2+1.20.1 Porting Lib Model Materials: 2.1.1090+1.20 Porting Lib Models: 2.3.2+1.20.1 Porting Lib Networking: 2.3.2+1.20.1 Porting Lib Obj Loader: 2.3.2+1.20.1 Porting Lib Tags: 3.0 Porting Lib Tool Actions: 2.3.2+1.20.1 Porting Lib Transfer: 2.3.2+1.20.1 Porting Lib Utility: 2.3.2+1.20.1 Reach Entity Attributes: 2.4.0 Registrate for Fabric: 1.3.62-MC1.20.1 ```
Server Info ``` Create: Mod Version: 0.5.1f Fabric API Version: 0.92.2+1.20.1 Minecraft Version: 1.20.1 System Information: Operating System: Windows 10 (amd64) version 10.0 Java Version: 18-beta, Eclipse Adoptium JVM Flags: 3 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xms512m -Xmx4096m Memory: 565367296 bytes (539 MiB) / 1990197248 bytes (1898 MiB) up to 4294967296 bytes (4096 MiB) CPU: AMD Ryzen 7 5800H with Radeon Graphics @ 3.19 GHz; 8 cores / 16 threads on 1 socket(s) Graphics card #0: NVIDIA GeForce RTX 3060 Laptop GPU (NVIDIA (0x10de)); 4095.00 MB of VRAM Other Mods: core: 3.6.6 toml: 3.6.6 jsr305: 3.0.2 Dripstone Fluid Lib: 3.0.2 Fabric API Base: 0.4.31+1802ada577 Fabric API Lookup API (v1): 1.6.36+1802ada577 Fabric Biome API (v1): 13.0.13+1802ada577 Fabric Block API (v1): 1.0.11+1802ada577 Fabric BlockView API (v2): 1.0.1+1802ada577 Fabric BlockRenderLayer Registration (v1): 1.1.41+1802ada577 Fabric Client Tags: 1.1.2+1802ada577 Fabric Command API (v1): 1.2.34+f71b366f77 Fabric Command API (v2): 2.2.13+1802ada577 Fabric Commands (v0): 0.2.51+df3654b377 Fabric Containers (v0): 0.1.64+df3654b377 Fabric Content Registries (v0): 4.0.11+1802ada577 Fabric Convention Tags: 1.5.5+1802ada577 Fabric Crash Report Info (v1): 0.2.19+1802ada577 Fabric Data Attachment API (v1): 1.0.0+de0fd6d177 Fabric Data Generation API (v1): 12.3.4+1802ada577 Fabric Dimensions API (v1): 2.1.54+1802ada577 Fabric Entity Events (v1): 1.6.0+1c78457f77 Fabric Events Interaction (v0): 0.6.2+1802ada577 Fabric Events Lifecycle (v0): 0.2.63+df3654b377 Fabric Game Rule API (v1): 1.0.40+1802ada577 Fabric Item API (v1): 2.1.28+1802ada577 Fabric Item Group API (v1): 4.0.12+1802ada577 Fabric Key Binding API (v1): 1.0.37+1802ada577 Fabric Key Bindings (v0): 0.2.35+df3654b377 Fabric Lifecycle Events (v1): 2.2.22+1802ada577 Fabric Loot API (v2): 1.2.1+1802ada577 Fabric Loot Tables (v1): 1.1.45+9e7660c677 Fabric Message API (v1): 5.1.9+1802ada577 Fabric Mining Level API (v1): 2.1.50+1802ada577 Fabric Model Loading API (v1): 1.0.3+1802ada577 Fabric Models (v0): 0.4.2+9386d8a777 Fabric Networking API (v1): 1.3.11+1802ada577 Fabric Networking (v0): 0.3.51+df3654b377 Fabric Object Builder API (v1): 11.1.3+1802ada577 Fabric Particles (v1): 1.1.2+1802ada577 Fabric Recipe API (v1): 1.0.21+1802ada577 Fabric Registry Sync (v0): 2.3.3+1802ada577 Fabric Renderer API (v1): 3.2.1+1802ada577 Fabric Renderer - Indigo: 1.5.2+85287f9f77 Fabric Renderer Registries (v1): 3.2.46+df3654b377 Fabric Rendering Data Attachment (v1): 0.3.37+92a0d36777 Fabric Rendering Fluids (v1): 3.0.28+1802ada577 Fabric Rendering (v0): 1.1.49+df3654b377 Fabric Rendering (v1): 3.0.8+1802ada577 Fabric Resource Conditions API (v1): 2.3.8+1802ada577 Fabric Resource Loader (v0): 0.11.10+1802ada577 Fabric Screen API (v1): 2.0.8+1802ada577 Fabric Screen Handler API (v1): 1.3.30+1802ada577 Fabric Sound API (v1): 1.0.13+1802ada577 Fabric Transfer API (v1): 3.3.5+8dd72ea377 Fabric Transitive Access Wideners (v1): 4.3.1+1802ada577 Fabric Loader: 0.16.3 Forge Config API Port: 8.0.0 OpenJDK 64-Bit Server VM: 18 Milk Lib: 1.2.60 MixinExtras: 0.4.1 Porting Lib Accessors: 2.3.2+1.20.1 Porting Lib Attributes: 2.3.2+1.20.1 Porting Lib Base: 2.3.2+1.20.1 Porting Lib Brewing: 2.3.2+1.20.1 Porting Lib Client Events: 2.3.2+1.20.1 Porting Lib Common: 2.3.2+1.20.1 Porting Lib Config: 2.3.2+1.20.1 Porting Lib Core: 2.3.2+1.20.1 Porting Lib Data: 2.1.1090+1.20 Porting Lib Entity: 2.3.2+1.20.1 Porting Lib Extensions: 2.3.2+1.20.1 Porting Lib Fluids: 2.3.2+1.20.1 Porting Lib GameTest: 2.1.1090+1.20 Porting Lib Lazy Register: 2.3.2+1.20.1 Porting Lib Mixin Extensions: 2.3.2+1.20.1 Porting Lib Model Generators: 2.1.1090+1.20 Porting Lib Model Loader: 2.3.2+1.20.1 Porting Lib Model Materials: 2.1.1090+1.20 Porting Lib Models: 2.3.2+1.20.1 Porting Lib Networking: 2.3.2+1.20.1 Porting Lib Obj Loader: 2.3.2+1.20.1 Porting Lib Tags: 3.0 Porting Lib Tool Actions: 2.3.2+1.20.1 Porting Lib Transfer: 2.3.2+1.20.1 Porting Lib Utility: 2.3.2+1.20.1 Reach Entity Attributes: 2.4.0 Registrate for Fabric: 1.3.62-MC1.20.1 ```
TropheusJ commented 2 months ago

The fabric version has much more adventure mode protection because of BlanketCon. This is intended. An overhaul of the system to make it configurable is planned but low priority.