Fabricators-of-Create / Create

[Fabric Mod] Building Tools and Aesthetic Technology
MIT License
834 stars 188 forks source link

Use convention tags #162

Closed JieningYu closed 1 year ago

JieningYu commented 2 years ago

Describe the Suggestion

No fabric mod except Create fabric use Forge tags so there’s a big compat issue between create and other fabric mods. For example, if player use create’s mechanical press to press a brass ingot into a brass sheet, in receives c:ingots/brass but not c:brass_ingots which most fabric mods are using. So only create’s brass ingot can be pressed into brass sheet using mechanical press. For another example, a player use a techreborn’s industrial grinder to grind a brass ingot into brass dust, but it only receives c:brass_ingots but not c:ingots/brass so only create’s brass ingot can’t grind. To fix this problem is easy, just change items/blocks’ tags into which most fabric mods use and change recipes’ required tags into which most fabric mods use but not forge tags. When this issue is fixed, the mod’s compatibility will be enhanced a lot.

Screenshots and Videos

No response

Additional Context

Just revert the changes from updating forge tags2.0.

AlphaMode commented 2 years ago

Imo we prefer forge tags layout and convention for now we are probably going to be keeping forgetags and a legacy system might be put in place later

JieningYu commented 2 years ago

Or a more convenient way is add all c:brass_ingots into c:ingots/brass and add all c:ingots/brass into c:brass_ingots so we can still keep forge tags system and have compatibility with other mods.

AlphaMode commented 2 years ago

Or a more convenient way is add all c:brass_ingots into c:ingots/brass and add all c:ingots/brass into c:brass_ingots so we can still keep forge tags system and have compatibility with other mods.

That's what I talk about when I say legacy system

TropheusJ commented 2 years ago

I've merged this into #140.

TropheusJ commented 1 year ago

un-merged since it's the only real thing left there. Will be handled in the 1.19 update.

JieningYu commented 1 year ago

um.. when will Create Fabric update to 1.19? (Create Forge has already been updated to 1.19)

maximumpower55 commented 1 year ago

Instead of commenting on a random issue, maybe ask on the discord instead next time :>

JieningYu commented 1 year ago

Instead of commenting on a random issue, maybe ask on the discord instead next time :>

This issue will be handled in the 1.19 update (by TropheusJ)

rlnt commented 1 year ago

The issue was not handled. Create Fabric still uses the wrong tag format...

JieningYu commented 1 year ago
image

...yes

rlnt commented 1 year ago

It seems like Fabric adds the same tag style to vanilla items tho So maybe that should be the convention instead and Create Fabric did the right thing here.

JieningYu commented 1 year ago

It seems like Fabric adds the same tag style to vanilla items tho So maybe that should be the convention instead and Create Fabric did the right thing here.

No, it's Forge Tags mod by Alphamode.

JieningYu commented 1 year ago

In convention tags it should be c:nether_bricks (or c:nether_brick_ingots)

TropheusJ commented 1 year ago

Forgot about this... Soon™️