Fabricators-of-Create / Create

[Fabric Mod] Building Tools and Aesthetic Technology
MIT License
834 stars 188 forks source link

Some resource packs cause the glowing shader to fail to load #217

Closed redstonerti closed 2 years ago

redstonerti commented 2 years ago

Describe the Bug

Create stops all resource packs from being loaded Here's a relevant line in the logs: Caused by: java.io.IOException: Couldn't compile vertex program (Fabric Mods, create:glowing_shader) : 0(29) : error C1503: undefined variable "cylindrical_distance"

Reproduction Steps

Download create Try to load any resource pack

Expected Result

The resource pack should load

Screenshots and Videos

No response

Crash Report or Log

https://mclo.gs/LrCXObo

Operating System

Windows 10

Mod Version

0.4.0d

Minecraft Version

1.18.1

Other Mods

No response

Additional Context

No response

digitaltrucker commented 2 years ago

That's a really old build, try build 445 (that's the one I use).

redstonerti commented 2 years ago

image https://mclo.gs/Ahh1SF8 I tried it with the latest build. The bug is still present

TropheusJ commented 2 years ago

latest builds are unusable, test 441 or 445

redstonerti commented 2 years ago

image This was the one I used, and everything else worked fine. It was usable. I will try it with 445 though just to be sure.

redstonerti commented 2 years ago

Just tested build 445, no difference

Blightbuster commented 2 years ago

Tested on 448 with this resource pack: https://resourcepack.net/wayukian-resource-pack/

Everything loads fine and I don't get any error.

@redstonerti could you please link the pack you used?

image

TropheusJ commented 2 years ago

image can't reproduce

Cart3r1234 commented 2 years ago

Featuring the almighty H Pack

redstonerti commented 2 years ago

I just tested it in build 445 with your resource pack, and it works. What doesn't work however, is this resource pack. fourniv6.zip Which is very weird to be honest. All I did was upscale some textures. Everything is a multiple of two and some small details have been added. I'm going to try and test it later with more resource packs and see what happens but this is all I have for now.

redstonerti commented 2 years ago

image Also yeah the same error happened as before. You could say that this is my fault, that I made a bad texture pack, but this error might cause problems with other packs as well. Mods: https://drive.google.com/file/d/1Db-0a-QTF8m-0kZaGzkijoKpNsjJ8S1T/view?usp=sharing Fabric version: 0.13.3-1.18.1

redstonerti commented 2 years ago

Yeah sorry, I should have changed the title myself. Were you able to reproduce this?

AlphaMode commented 2 years ago

Can you test this on forge too

redstonerti commented 2 years ago

Can you test this on forge too

We were playing on forge with this resource pack before switching to fabric. I guess I could test it again on the latest version but I am 99.99% sure that it works on forge.

TropheusJ commented 2 years ago

I've figured out that if a resource pack defines core shaders, flywheel shaders will fail to load. This example pack seems to be made exceptionally terribly, and seems to bundle duplicates of vanilla resources, including shaders.

TropheusJ commented 2 years ago

further investigation: the pack has a messed up include/fog.glsl shader. The fog_distance function is just missing.

TropheusJ commented 2 years ago

to my understanding this is just a flaw in the pack.