Fabricators-of-Create / Create

[Fabric Mod] Building Tools and Aesthetic Technology
MIT License
834 stars 188 forks source link

1.18.2 Ready Version (Build 485) Crash #231

Closed digitaltrucker closed 2 years ago

digitaltrucker commented 2 years ago

Describe the Bug

Game crashes on launch.

Reproduction Steps

  1. Attempt to launch game
  2. ???

Expected Result

Game launches.

Screenshots and Videos

No response

Crash Report or Log

https://pastebin.com/YFX2sU82

Operating System

Windows 10

Mod Version

0.4.0f

Minecraft Version

1.18.1

Other Mods

No response

Additional Context

Actually Minecraft 1.18.2, that option just isn't selectable in the dropdown box.

MattiDragon commented 2 years ago

Related to nightconfig

digitaltrucker commented 2 years ago

What's that?

Edit: Never mind, not on my end anyway.

Kneelawk commented 2 years ago

From the error log, we can see that com_electronwill_night-config_core and com_electronwill_night-config_toml aren't getting loaded, despite being JIJ'd in the create jar, while com_google_code_findbugs_jsr305 (also JIJ'd in create) is getting loaded.

No clue as to what could be causing this though.

Kneelawk commented 2 years ago

Extracting the META-INF/jars/core-3.6.3.jar and META-INF/jars/toml-3.6.3.jar files from the create jar and copying them into the mods folder, then changing their mod-ids to replace all instances of - with _ appears to have fixed the issue and these libraries are now being loaded by fabric-loader.

My guess is that this is a bug in fabric-loader.

TropheusJ commented 2 years ago

Please test this with build 487+.

StockiesLad commented 2 years ago

Same issue on 488

digitaltrucker commented 2 years ago

Build 490 is still crashing the game, but it seems to be different as it no longer creates a log in the crash-reports folder. Instead it generates a regular log.

https://pastebin.com/BZNX3nWK

ThinkWithPbody commented 2 years ago

Using build 490 and the game crashes on launch for me too. I don't see a crash report though, only the "Minecraft has crashed!" error report from fabric loader.

https://pastebin.com/9mwZZkGV Edit: Full log https://pastebin.com/L7EtEcxh

sybershot commented 2 years ago

Same goes for me. Using build 490 crashes the game. Mods that i have:

TropheusJ commented 2 years ago

It’s almost like rewriting entire systems and updating to a new Minecraft version are likely to break things. I’ve already fixed this issue locally, I just need to finish up some other things with transfer.

StockiesLad commented 2 years ago

It’s almost like rewriting entire systems and updating to a new Minecraft version are likely to break things. I’ve already fixed this issue locally, I just need to finish up some other things with transfer.

It was just a joke! I appreciate ur hardwork just wanted to make some people laugh. I know its difficult and I didnt mean to offend u.

Polarite commented 2 years ago

we are happy with the improvements create fabric having to be honest. It is amazing that great mod is being ported to fabric!

redstonerti commented 2 years ago

we are happy with the improvements create fabric having to be honest. It is amazing that great mod is being ported to fabric!

This. Thank you tropheus for your hard work and for saving our fps.

StockiesLad commented 2 years ago

I deleted the comment! It was an ass move. My bad!

Suguowe commented 2 years ago

Thanks for your work!

ThinkWithPbody commented 2 years ago

Build 491 causes the game to crash on launch for me too. Thanks for your hard work! Log: https://pastebin.com/V0f3BY6C

Build 492 seems to work! Please ignore :)

TropheusJ commented 2 years ago

this is the lithium crash that I just fixed.