Fabricators-of-Create / Create

[Fabric Mod] Building Tools and Aesthetic Technology
MIT License
834 stars 188 forks source link

several mods compat #245

Closed JieningYu closed 2 years ago

JieningYu commented 2 years ago
JieningYu commented 2 years ago

I only edited compat data. A problem occurred configuring root project 'Create'.

Could not resolve all files for configuration ':detachedConfiguration2'. Could not find org.quiltmc:quilt-mappings:1.18.2+build.21.

TropheusJ commented 2 years ago

Ignore the build, mavens are funky right now

JieningYu commented 2 years ago

is create supported quilt?

TropheusJ commented 2 years ago

We use quilt mappings for docs and params. Latest commit fixed build.

JieningYu commented 2 years ago
  • ae2(updated one)
  • promenade
  • alloy forgery(creative blaze cake is 96000 because it's deepslate forge's max fueltier.)
  • mores
  • unearthed
  • universal ores they all has fabric:load_conditions except alloy forgery fuels because it won't load without alloy forgery.

now with betternether and immersive weathering support

JieningYu commented 2 years ago

JieningYu commented 2 years ago

hi?

AlphaMode commented 2 years ago

your pr is modifying content from the forge version and I don't think it will be accepted unless you reverse it

JieningYu commented 2 years ago

ok

JieningYu commented 2 years ago

no modifies now

JieningYu commented 2 years ago

now with:

TropheusJ commented 2 years ago

Will try to review this today

StockiesLad commented 2 years ago

Ok to be clear im not asking u to do any of these, this is just for everybody to get some insight:

Create (crushing) still doesn't process ores from:

modern industrialisation Mythic metals (idk why????) Better end (it isn't working?) Excavated Variants (this uses JSON's so it would be easier) Industrial revolution paradise lost space dimensions (agape space)

Side thing: since this is create plus, electricity compat?

EDIT: thank you JieningYu for your help!

TropheusJ commented 2 years ago

A lot of these would likely be fixed by tags, which we’re looking into.

StockiesLad commented 2 years ago

A lot of these would likely be fixed by tags, which we’re looking into.

Fair enough. You guys are doing F&ing great! Like there are no word. Just thank you guys for all the work you are putting into this. Getting bugs fixed in literal hours. Fantastic job! Keep it up.

JieningYu commented 2 years ago

Ok to be clear im not asking u to do any of these, this is just for everybody to get some insight:

Create (crushing) still doesn't process ores from:

modern industrialisation

Mythic metals (idk why????)

Better end (it isn't working?)

Excavated Variants (this uses JSON's so it would be easier)

Industrial revolution

paradise lost

space dimensions (agape space)

Side thing: since this is create plus, electricity compat?

EDIT: thank you JieningYu for your help!

This PR is not CreatePlus. If you want Mythic Metals compat, use the original CreatePlus mod/datapack(datapack dosen't include custom crushed ors feature)

modern industrialisation and paradise lost is planned but agape space and Industrial revolution not Will support mods that requires bclib when quilted fabric api is out of beta.

StockiesLad commented 2 years ago

Ok to be clear im not asking u to do any of these, this is just for everybody to get some insight: Create (crushing) still doesn't process ores from: modern industrialisation Mythic metals (idk why????) Better end (it isn't working?) Excavated Variants (this uses JSON's so it would be easier) Industrial revolution paradise lost space dimensions (agape space) Side thing: since this is create plus, electricity compat? EDIT: thank you JieningYu for your help!

This PR is not CreatePlus. If you want Mythic Metals compat, use the original CreatePlus mod/datapack(datapack dosen't include custom crushed ors feature)

modern industrialisation and paradise lost is planned but agape space and Industrial revolution not Will support mods that requires bclib when quilted fabric api is out of beta.

One question, why support quilt when supporting fabric is supporting 2 loaders simultaneously EDIT: and btw Thank you for the input!

JieningYu commented 2 years ago

Ok to be clear im not asking u to do any of these, this is just for everybody to get some insight: Create (crushing) still doesn't process ores from: modern industrialisation Mythic metals (idk why????) Better end (it isn't working?) Excavated Variants (this uses JSON's so it would be easier) Industrial revolution paradise lost space dimensions (agape space) Side thing: since this is create plus, electricity compat? EDIT: thank you JieningYu for your help!

This PR is not CreatePlus. If you want Mythic Metals compat, use the original CreatePlus mod/datapack(datapack dosen't include custom crushed ors feature) modern industrialisation and paradise lost is planned but agape space and Industrial revolution not Will support mods that requires bclib when quilted fabric api is out of beta.

One question, why support quilt when supporting fabric is supporting 2 loaders simultaneously EDIT: and btw Thank you for the input!

to allure more players to use Quilt

StockiesLad commented 2 years ago

Quilt is essentially just another fork of fabric that really doesn't have more then fabric (as of now). Switching modloaders is a mere inconvenience, there is nothing special about quilt aside from it being just another modloader...

JieningYu commented 2 years ago

Quilt is essentially just another fork of fabric that really doesn't have more then fabric (as of now). Switching modloaders is a mere inconvenience, there is nothing special about quilt aside from it being just another modloader...

Quilt has QSL and more features compared with Fabric.

StockiesLad commented 2 years ago

Quilt is essentially just another fork of fabric that really doesn't have more then fabric (as of now). Switching modloaders is a mere inconvenience, there is nothing special about quilt aside from it being just another modloader...

Quilt has QSL and more features compared with Fabric.

and disproportionately more bugs.

maximumpower55 commented 2 years ago

Quilt is essentially just another fork of fabric that really doesn't have more then fabric (as of now). Switching modloaders is a mere inconvenience, there is nothing special about quilt aside from it being just another modloader...

Quilt has QSL and more features compared with Fabric.

and disproportionately more bugs.

Its still in beta :/

StockiesLad commented 2 years ago

Quilt is essentially just another fork of fabric that really doesn't have more then fabric (as of now). Switching modloaders is a mere inconvenience, there is nothing special about quilt aside from it being just another modloader...

Quilt has QSL and more features compared with Fabric.

and disproportionately more bugs.

Its still in beta :/

Indeed! Time will tell how effective quilt is.

JieningYu commented 2 years ago

i give up this pr. check createplus if you want better compat.

StockiesLad commented 2 years ago

I'm gonna wait for the tag fix by them.

StockiesLad commented 2 years ago

Bc quilt is too glitchy to use just crashing all the time

StockiesLad commented 2 years ago

LambdAuora I'm just waiting for u to dislike this too lmao.

JieningYu commented 2 years ago

Bc quilt is too glitchy to use just crashing all the time

a create+ datapack for fabric exists

JieningYu commented 2 years ago

https://github.com/JieningYu/CreatePlus/archive/refs/heads/datapack/fabric/1.18.2.zip

StockiesLad commented 2 years ago

Thank you for the direct link!

JieningYu commented 2 years ago

unarchive zhe zip before using

maximumpower55 commented 2 years ago

Bc quilt is too glitchy to use just crashing all the time

Instead of Whining about it, how about you actually report the crash :/

StockiesLad commented 2 years ago

unarchive zhe zip before using

👍

StockiesLad commented 2 years ago

Bc quilt is too glitchy to use just crashing all the time

Instead of Whining about it, how about you actually report the crash :/

Nah, how about I don't.