KubeJS compat and better tags

[StockiesLad]

Describe the Suggestion

I was trying to get create to work with other mods' ores, ingots etc. Things like getting the crushing wheel to properly process other ores. All the trial and error to no avail. My concern is that since create (fabric) uses forge tags, it doesn't work at all with anything else besides vanilla. I already assume you guys are aware of this and I'm curious about the plans of mitigation.

Screenshots and Videos

No response

Additional Context

No response

[Arathain]

if you want it to work with other mods, I'd think that editing the base tags yourself would be viable, seeing as none of this is hardcoded

[JieningYu]

try CreatePlus. https://modrinth.com/mod/createplus it can fix issue about tags.

[JieningYu]

try CreatePlus. https://modrinth.com/mod/createplus it can fix issue about tags.

https://github.com/Fabricators-of-Create/Create/pull/245 Pull Request about this

[StockiesLad]

try CreatePlus. https://modrinth.com/mod/createplus it can fix issue about tags.

trying it now.

[StockiesLad]

Oh wait, its for quilt exclusively... Does it really have to be exclusive for quilt?

[JieningYu]

It has a datapack format. https://cdn.modrinth.com/data/svgZx0UN/versions/1.0-beta2/CreatePlus%20Datapack.zip

[StockiesLad]

oh ok thanks!

[StockiesLad]

Any plans to have fabric support in your mod addon.

[JieningYu]

Any plans to have fabric support in your mod addon.

It's easy to port(you can port yourself or use Quilt. Most of Fabric mods can play on Quilt.

[StockiesLad]

Any plans to have fabric support in your mod addon.

It's easy to port(you can port yourself or use Quilt. Most of Fabric mods can play on Quilt.

quilt is very buggy. I'm building from source anyways so it's all good.

[JieningYu]

Any plans to have fabric support in your mod addon.

It's easy to port(you can port yourself or use Quilt. Most of Fabric mods can play on Quilt.

quilt is very buggy. I'm building from source anyways so it's all good.

note that the source doesn't include createplus-core(datapack) by default.

[StockiesLad]

[B#744] Caused by: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: Critical injection failure: @Inject annotation on port_lib$clientStartTickEvent could not find any targets matching 'Lnet/minecraft/class_1657;tick()V' in net.minecraft.class_1657. Using refmap porting_lib-refmap.json [PREINJECT Applicator Phase -> porting_lib.mixins.common.json:PlayerMixin from mod porting_lib -> Prepare Injections -> -> handler$zeg000$port_lib$clientStartTickEvent(Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;)V -> Parse]

It spits out this error when I use the compiled version.

[JieningYu]

[B#744] Caused by: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: Critical injection failure: @Inject annotation on port_lib$clientStartTickEvent could not find any targets matching 'Lnet/minecraft/class_1657;tick()V' in net.minecraft.class_1657. Using refmap porting_lib-refmap.json [PREINJECT Applicator Phase -> porting_lib.mixins.common.json:PlayerMixin from mod porting_lib -> Prepare Injections -> -> handler$zeg000$port_lib$clientStartTickEvent(Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;)V -> Parse]

It spits out this error when I use the compiled version.

how you compile?

[StockiesLad]

I changed the port lib hash to the new one.

[JieningYu]

createplus don't need port lib and you can use the latest version of create fabric directly.

[StockiesLad]

I was talking about ur PR of create

[JieningYu]

fetched upstream

[StockiesLad]

fetched upstream

Is it getting merged now? Or is it already merged.

[StockiesLad]

oh i saw...

[StockiesLad]

latest.log It causes a porting lib issue tho...

[StockiesLad]

Player Mixin is failing

[JieningYu]

?

[JieningYu]

if it's a mixin issue, report it to TropheusJ

[StockiesLad]

if it's a mixin issue, report it to TropheusJ

ok

[TropheusJ]

KubeJS support: https://www.curseforge.com/minecraft/mc-mods/kubejs-create we will be handling tags with the 1.19 update.

[JieningYu]

pog

[TropheusJ]

tag change happened