Fabricators-of-Create / Create

[Fabric Mod] Building Tools and Aesthetic Technology
MIT License
834 stars 188 forks source link

The menu button is missing, when used with mods, that add their language files to minecraft namespace #588

Closed SplendidAlakey closed 1 year ago

SplendidAlakey commented 1 year ago

Describe the Bug

The Create menu button is missing on 1.19.2, if any mod, that adds its own language files into the minecraft namespace, is also present.

Reproduction Steps

  1. Install this build on Fabric
  2. Install a mod, that adds its own language files to the minecraft namespace, e.g. Incendium, BetterBiomeBlend, Consistency+.
  3. Run the game

Expected Result

There should be a menu button.

Screenshots and Videos

No response

Crash Report or Log

No response

Operating System

Windows 10

Mod Version

0.5.0f

Minecraft Version

1.19.2

Other Mods

Incendium BetterBiomeBlend Consistency+

Additional Context

The issue is exclusive to Fabric, Quilt is unaffected.

JieningYu commented 1 year ago

weird. Incendium is just a jarred datapack.

AlphaMode commented 1 year ago

The mod is closed source can't really do anything

SplendidAlakey commented 1 year ago

The mod is closed source can't really do anything

Yeah, figured as much. Should I keep the issue open for visibility or nah?

Skidamek commented 1 year ago

Incendium is completely server-side, you can just remove it from client

SplendidAlakey commented 1 year ago

I'm not playing on a server, though.

Skidamek commented 1 year ago

Makes sense

Skidamek commented 1 year ago

However becouse Incendium mod is just a jarred datapack as JieningYu said, you can try to use a normal datapack version of Incendium https://www.planetminecraft.com/data-pack/incendium-nether-expansion/

JieningYu commented 1 year ago

No. there's a class in that mod

AkashiiKun commented 1 year ago

The class is just an event registry which does nothing. (Blurred something as I'm not supposed to use a decompiler) image

And the only class is for forge. Also, it doesn't even have the seed fix as is already in the vanilla game. So definitely with using the datapack is enough.

JieningYu commented 1 year ago

so.. why Incendium can cause that?

SplendidAlakey commented 1 year ago

It's caused by their language files somehow. I was wrong in my initial claim, that Quilt is unaffected by this bug, I just had my Incendium jar bootleg "patched". I moved their language files out of minecraft namespace to it's own to avoid a bug with Minekea. But I just tested a clean Incendium jar on Quilt and the bug occurred.

SplendidAlakey commented 1 year ago

I updated the issue to reflect the actual bug: the menu button disappears, if another mod adds its own language files to minecraft namespace. Removed the logs, because there's nothing in them anyway.

I've experienced a similar issue before with Minekea, except, in their case, blocks have broken translation strings: https://github.com/chimericdream/minekea-fabric/issues/67

TropheusJ commented 1 year ago

Issue is probably this line

SplendidAlakey commented 1 year ago

Not fixed. The issue became worse after the patch (build 766), the button now doesn't appear at all, no mods, en_us game language. But this time, the logs do seem to mention a related error: https://gist.github.com/SplendidAlakey/c2ad83bc17cbb5e3b7ea04cddddab941

TropheusJ commented 1 year ago

???

TropheusJ commented 1 year ago

Super weird. I've encountered this issue before with Consistency+. Somehow having lang in the vanilla namespace makes translations just not work at the stage the button is added.