Fabricators-of-Create / Create

[Fabric Mod] Building Tools and Aesthetic Technology
MIT License
834 stars 188 forks source link

Crash with NBT Crafting #596

Closed digitaltrucker closed 1 year ago

digitaltrucker commented 1 year ago

Describe the Bug

Trying to hand crank a mechanical press crashes the game. Trying to reload the world afterwards crashes the game.

Reproduction Steps

  1. Place mechanical press, basin, and hand crank to make iron sheets.
  2. Use it.
  3. ...

Expected Result

Game doesn't crash and world doesn't become unloadable.

Screenshots and Videos

No response

Crash Report or Log

https://pastebin.com/q83bt0uQ

Operating System

Windows 10

Mod Version

0.5.0f

Minecraft Version

1.19.2

Other Mods

Additional Context

Using release version of Create (build 776).

TropheusJ commented 1 year ago

Try removing NBT Crafting

digitaltrucker commented 1 year ago

That worked. Sadly, NBT Crafting is loaded via Wilder Wild, so that's the mod conflict. Naturally, removing that mod at this point wrecks the world anyway...

SplendidAlakey commented 1 year ago

Sprice Of Fabric also ships NBT Crafting, though, thankfully, that one is easily removed with no consequences.

Also, how did you even come up with an idea to try and press something in a basin, lol?

Ahhh, you press 9 pieces into blocks that way, didn't know!

digitaltrucker commented 1 year ago

Do you think this world will be playable in the future after a bugfix or is it perma-toast?

SplendidAlakey commented 1 year ago

I was able to load into my world after crashing the way you described, when I removed NBT Crafting. So I assume the basin press doesn't corrupt anything on its own. Just don't remove neither Create nor Wilder Wild, while loading the world.

digitaltrucker commented 1 year ago

NBT Crafting is loaded via Wilder Wild though, it's not a discrete mod. How do I remove it without removing Wilder Wild?

SplendidAlakey commented 1 year ago

Since you asked about "the future after a bugfix", I meant exactly that - whenever the issue gets fixed, the world should load just fine. Until then, don't try loading it without Create or WW.

Out of curiosity, you could try opening WW with an archive manager and removing NBT Crafting from JiJ, but it's very likely to cause a crash and potentially corrupt something anyway. I have no idea what they use the mod for, so I don't recommend doing it.

TeaJeep commented 1 year ago

Updating Create to 0.5.0g and WilderWild to 1.1.2 resolved this for me. I presume the Create update fixed this? Specifically for me, though, the issue started when I tried to make brass in a basin, unrelated to a hand crank or press.

SplendidAlakey commented 1 year ago

the issue started when I tried to make brass in a basin, unrelated to a hand crank or press.

That was a different issue. Hand cranking above a basin still causes a crash with NBT Crafting.

TeaJeep commented 1 year ago

Oh! My bad then, sorry for the misunderstanding!

digitaltrucker commented 1 year ago

Yep, issue is resolved as far as I can tell :)

SplendidAlakey commented 1 year ago

Huh? I'm going to double check, but at least with Spice Of Fabric it wasn't resolved. Maybe I need to add an updated standalone NBT Crafting...

SplendidAlakey commented 1 year ago

Oh, yeah, it is fixed. Just had to update NBT Crafting separately. Sorry, TeaJeep, for the confusion.