Fabricators-of-Create / Create

[Fabric Mod] Building Tools and Aesthetic Technology
MIT License
834 stars 188 forks source link

Game Crashes when using Map/Treasure Map #785

Open SolacianAllie opened 1 year ago

SolacianAllie commented 1 year ago

Describe the Bug

The game crashes as soon as one obtains a treasure map or regular map, closing the game or booting you from a server(varies, as running on vanilla servers but with mods loaded locally the game boots from server but when on the server with said mod it causes a full on game close) ive been locked out of several servers i play on because of this, and i cannot even contact the owners on half of them to edit my inventory data to remove them

Reproduction Steps

1.Open up with create fabric, plus other create expansion mods for 1.19.2 2.obtain a treasure map or regular map 3.game crashes or boots you from server ...

Expected Result

map opens and no crash occurs

Screenshots and Videos

No response

Crash Report or Log

No response

Operating System

Windows 10

Mod Version

0.5.0h

Minecraft Version

1.19.2

Other Mods

AmbientSounds 5 Architectury API Cloth Config Continual Music Create Chunkloading Create Crafts&Additions Create Deco Fabric Create Fabric(obv) Create Extended Flywheels Creative Core Drip Sounds Dabric Dynamic Surroundings Fabric Fabric API Indium IRIS Shaders Just Enough Items ModMenu Presence footsteps Skin Layers3D Sodium World Edit Server Core Meteor Client

Additional Context

havent yet tested a vanilla client, but id assume the bug wouldnt occur, the reason i play most vanilla servers with my modded game is because of my shaders and other stuff bundled in, its easier

TropheusJ commented 1 year ago

log?

TropheusJ commented 1 year ago

Can you test the latest release?

SolacianAllie commented 1 year ago

tested latest release and its still a issue, ill attempt to look through logs sometime soon when possible image thats the error ive been getting, others had similar issues pointing towards create mod, so i think its the same here

aria1th commented 1 year ago

This is Packet Size Limit issue, not directly create's fault but now vanilla has hardcoded limits for packet size, try using https://github.com/aria1th/XLPacketsFabric/releases/tag/1.0.0-1.19.2 (both in server and client)

TropheusJ commented 1 year ago

That’s not packet limits, that’s a broken one. Send the entire client and server logs.

SolacianAllie commented 1 year ago

sadly the server isnt mine, so server logs are out of the question, but i cleared my logs and then rejoined the server, joined survival which gives a map automatically, and crashed immidiately latest.log

TropheusJ commented 1 year ago

Wait, does the server not have Create installed?

SolacianAllie commented 1 year ago

it doesnt, but even on my personal server with the create installed it crashes, my profile has some mods that add stuff but also majority of them are client only mods, so its easier to just use one profile

TropheusJ commented 1 year ago

Using content mods on servers without them will never work right and is not supported. Any issues with that will not be fixed.

I would like to see the log of your server with Create. Put it on https://mclo.gs/ to automatically strip IPs.

SolacianAllie commented 1 year ago

i just loaded up a test server under my bungee and it seems to be fine, wierd, it appears fine now for some odd reason, ill continue trying over the next week or so, just to see if there was something else to it, atleast on my create servers atleast

FreeMonoid commented 1 year ago

I understand that this issue isn't directly related to Create, but I am seeking a workaround to address it. Any suggestions or guidance on potential solutions would be greatly appreciated!

For example, would a mod that entirely disables map rendering fix this, or would I need to modify the networking code, given that Netty appears in the stack trace?

To provide some additional context: I am operating several near-vanilla (Paper) servers and an industrial Fabric server behind a Velocity proxy, and I'm looking to add a Create server to this setup. My players are currently able to use the industrial modpack on vanilla servers (without ability to use any modded content, of course), and I would like to offer them a similar option with a Create modpack.