search

Fabricio20 / HubBasics

Bukkit Plugin For Hub Owners
GNU Lesser General Public License v3.0
22 stars 11 forks source link

Proposed change to fix nbt item issues on "unsupported" versions #153

Closed W4545 closed 3 years ago

W4545 commented 3 years ago

Many of my pull requests have centered around adding NMSVersions for newer Minecraft versions because the plugin's JoinItem module breaks after every update because the getRunningNMS() function returns "Unknown." This change will make it so the plugin uses the current NMS package when the NMSVersion is "Unsupported." I do concede this is more of a band aid fix to the problem, but it will fix issues for most users when there is an update to the API level that doesn't alter anything major. This also preserves the notion that the plugin is "unsupported" on those versions so server owners know that if they encounter issues its because the plugin hasn't been officially tested for that version.

Fabricio20 commented 3 years ago

Thank you so much for the contribution!