search

Fabrik / fabrik

Fabrik for Joomla 3.x
http://fabrikar.com
Other
254 stars 380 forks source link

list email plugin, WYSIWYG editor enabled #1700

Open trob opened 8 years ago

trob commented 8 years ago

latest joomla3 git:

trob commented 8 years ago

GitHub master 2016-06-06 It's still not resizeable but at least has a scroll bar.

Now not only HTML is ignored but it doesn't take any text modification (always sending the original text from the plugin setting). This is only if WYSIGWIG editor is enabled, it's ok if the editor (JCE) is "toggled" to show the source.

The email popup is breaking all other list buttons (dropdowns like groupby, csv, Fabrik actions...)

trob commented 8 years ago

Other buttons are ok now.

The message content issue is editor related. I'm logged in as superadmin, so no J! content filter should apply. But it doesn't make any difference if J!text filters are set to "no filtering" for public

With JCE: I can edit the text but it's sending the original text from email plugin settings (but stripping HTML inserted in this setting). But this is only if the editor is in WYSIWYG mode, if it's toggled and showing the plain code the modified text is sent (but without HTML).

With MCE: it's sending the modified text (without HTML) with editor "on" or "off"

trob commented 8 years ago

HTML stripping: in \plugins\fabrik_list\email\models\email.php around line 642 it's doing $coverMessage = $input->get('message', '', 'html'); and the 'html' filter is stripping all html (I never understand this logic) https://docs.joomla.org/Retrieving_request_data_using_JInput

cheesegrits commented 8 years ago

I changed it to 'raw' last night. It went in a commit mostly for that kml overlay stuff.