search

Fabrik / fabrik

Fabrik for Joomla 3.x
http://fabrikar.com
Other
254 stars 380 forks source link

Reorder fieldExists parameters to keep php8 happy #2255

Closed skurvish closed 2 years ago

skurvish commented 2 years ago

PHP8 is strict about required parameters following optional ones. The PR simply reorders the parameters so the optional one is last.

trob commented 2 years ago

Not sure if it's the best way to reorder params of a public function. It may be used by somebody.

skurvish commented 2 years ago

The other option is to give the elGroupModel a default, perhaps null? I can reword this PR if that works for you.