Fabrik / fabrik

Fabrik for Joomla 3.x
http://fabrikar.com
Other
254 stars 381 forks source link

legends on google chart when chrt type is single line chart #76

Closed minijoomla closed 12 years ago

minijoomla commented 12 years ago

i create a google chart with single line chart type and added 2 line chart. 1- Height changes based on time ----> and set legend label to Height 2- Weight changes based on time -----> and set legend label to weight

and i set show legend to yes

but on chart pic legends show dates (x-axix)

pic link : http://chart.apis.google.com/chart?chs=750x400&chd=t:100,100,90,80|190,70,170,175|30,30,40,40|110,60,55,50|115,65,60,60|50,35,30,30|80,50,40,38&cht=lc&chco=00FF00,FF0000,0000FF,F0F000,000000,F000F0,FFCCCC&chxt=x,y&chxl=0:|1390-07-30%2002:43:18|1390-07-30%2003:32:11|1390-08-05%2022:01:56|1390-08-07%2002:03:39|1:|0|10|20|30|40|50|60|70|80|90|100|110|120|130|140|150|160|170|180|190|200&chds=0,200&chm=N,00FF00,0,-1,10|o,00FF00,0,-1,8|N,FF0000,1,-1,10|o,FF0000,1,-1,8|N,0000FF,2,-1,10|o,0000FF,2,-1,8|N,F0F000,3,-1,10|o,F0F000,3,-1,8|N,000000,4,-1,10|o,000000,4,-1,8|N,F000F0,5,-1,10|o,F000F0,5,-1,8|N,FFCCCC,6,-1,10|o,FFCCCC,6,-1,8&chdl=1390-07-30%2002:43:18|1390-07-30%2003:32:11|1390-08-05%2022:01:56|1390-08-07%2002:03:39&chg=-1,5,3,3

cheesegrits commented 12 years ago

I need to confirm this with Rob, but i suspect we may be dumping the Google charts viz, and focusing on the Fusion Charts viz moving forward. Now that FC have released the 2.3 free version, with no watermarks or backlinks to their site, and we've succesfully integrated the new version in the f2 version of the plugin (so it's just a case of copying some changes over to f3) I don't really see any advantage in keeping the Google charts viz going. It has no features that FC doesn't have, and has a lot of limitations that FC don't have.

Can you perhaps try doing the same chart you are building with the Google viz, in the FC viz? See if it has the same issue?

Some of the core code that collects and sums the table data is shared between the two plugins, but much of it has been re-written and improved for FC.

-- hugh

cheesegrits commented 12 years ago

Hmmm, as Rob pointed out, Google charts viz has the advantage of running on iOS, which FC won't because it is Flash based.

I think FC may be introducing an HTML5 option at some point, so I need to dig up some info on that before we make a decision.

-- hugh

minijoomla commented 12 years ago

yes, you right. but i think this problem will fix by change below cod in plugins/fabrik_visualization/chart/models/chart.php

    if ($legends) {
        $qs .= '&chdl=' . implode('|', $this->getAxisLabels($c));
    }

because getAxisLabels($c) get x-axis not legends

suggestion: write a function that get legend and color of each line . named getLegends($c)

pollen8 commented 12 years ago

If you know what the issue is can you make a pull request with the required code changes?

pollen8 commented 12 years ago

I've added a new field to the chart plugin which basically allows you to define any additional google chart properties which I think resolves this issue