Fabrizz / MMM-OnSpotify

Highly customizable MM2 module that displays what you are listening to in Spotify. Compatible with MMM-LiveLyrics and DynamicTheming.
MIT License
62 stars 10 forks source link

feature request: album cover resizing #14

Closed DarkPlayerr closed 8 months ago

DarkPlayerr commented 1 year ago

i installed mmm-onspotify and it works great, but i find the album cover a bit too big (although that could just be my 768p display) would love to see an option to make it smaller (small, medium, large perhaps?)

the medium one could be the width of the spotify bar code, as right now there's a wide padding on the sides, maybe the medium size album cover would be the width of the bar code with all of it's paddings (top/bottom/left/right) matching?

i made a quick concept to visualize it: Frame 251

also, it would be cool, if it was possible to hide the pipe thing that's on the left of the song title/artist

Fabrizz commented 1 year ago

Hey, im going t oadd an option to remove the pipe thing, about the sizing you can change the font size that calculates everything else:

.ONSP-Custom {
  font-size: 16px;  /* Font size controls all the relative sizings */
}

If that does not work let me know.

Also did you have any problems with a white background? I did not know people used that, but for non mirror displays I imagine it would look nice

Fabrizz commented 1 year ago

Just added the pipe hide option! also fixed LiveLyrics

DarkPlayerr commented 1 year ago

Hey, im going t oadd an option to remove the pipe thing, about the sizing you can change the font size that calculates everything else:

.ONSP-Custom {
  font-size: 16px;  /* Font size controls all the relative sizings */
}

If that does not work let me know.

Also did you have any problems with a white background? I did not know people used that, but for non mirror displays I imagine it would look nice

oh, it's a figma concept i made quick to visualize it, not my actual setup 😅

thanks for adding the change, appreciate it! ❤️

DarkPlayerr commented 1 year ago

i noticed some scaling/padding issues with the smaller font but it's no biggie

this is how the no music playing screen looks by default Screenshot at 2023-05-18 00-15-33~2.png

and this is how it looks after being rescaled to 22px (i think) Screenshot at 2023-05-18 00-16-55~2.png

DarkPlayerr commented 9 months ago

just updated mmm-onspotify, but the custom css for the smaller font stopped working. i saw the implementation being changed and besides

.ONSP-Custom {
  font-size: 16px;  /* Font size controls all the relative sizings */
}

in my css/custom.css i've toggled experimentalCSSOverridesForMM2: true in my config.js to no avail.

am i missing anything?

Fabrizz commented 9 months ago

Thats strange, as the last version does not add/removes/changes any of the theming/css parts, just adds device filtering. I would add the custom CSS to the custom.css file of MM2, not te module by itself, also I would add an !important so it has priority.

Fabrizz commented 9 months ago

experimentalCSSOverridesForMM2 is for applying color to other modules, it accepts an array. Readme has a couple of examples

DarkPlayerr commented 9 months ago

Thats strange, as the last version does not add/removes/changes any of the theming/css parts, just adds device filtering. I would add the custom CSS to the custom.css file of MM2, not te module by itself, also I would add an !important so it has priority.

i haven't updated my modules in ages, so it might've been the issue. anyways, !important in the mm2 css worked great, thanks.