search

Fabrizz / MMM-OnSpotify

Highly customizable MM2 module that displays what you are listening to in Spotify. Compatible with MMM-LiveLyrics and DynamicTheming.
MIT License
53 stars 9 forks source link

Check results of your module #48

Closed KristjanESPERANTO closed 4 months ago

KristjanESPERANTO commented 5 months ago

Thanks for this nice modul! :smiley:

I am working on a new module list and analyzing all the modules that are on the official list and collecting a few notes on what could perhaps be adapted. You can find them here. Maybe you would like to tackle a few of them. I would be happy to receive feedback.

Fabrizz commented 4 months ago

Hi, the automatic recommendations are awesome, will change all the typos and some best practices. node-fetch is difficult as some people are running really old node versions and it just breaks their mm2 install.

About the screenshot it would be nice to have a.mmdata.json (.mm2github.json, .magicmirror.yml, etc) file in the root of the directory to tell the crawler(? things like what picture to use, or if i want to suscribe to the notes? Maybe if it ends in MagicMirror2 or part of the docs, this file could be used for other things. (I have to say, the image selected for all the modules is correct every time, mine is just downloaded on lower quality)

About the page, in mobile the card are smaller than the screen width, some icons are not shown. In desktop I would have a max width for the card container, as if the screen is too big it would just expand.

KristjanESPERANTO commented 4 months ago

Thanks for the positive feedback! :smiley:

node-fetch is difficult as some people are running really old node versions and it just breaks their mm2 install.

You can of course stay with node-fetch for as long as you like. From my point of view, people should update their system from time to time, even if it is inconvenient.

About the screenshot it would be nice to have a.mmdata.json (.mm2github.json, .magicmirror.yml, etc) file in the root of the directory to tell the crawler(? things like what picture to use, or if i want to suscribe to the notes?

Good idea! There is already a similar plan. The idea is to extend the package.json with an MM section. But that's not my focus at the moment.

If you now want a different image for your module, add "screenshot" or "example" anywhere in the file name.

or if i want to suscribe to the notes?

I don't understand what you mean by that, sorry. Can you describe this in more detail?

About the page, in mobile the card are smaller than the screen width, some icons are not shown. In desktop I would have a max width for the card container, as if the screen is too big it would just expand.

I'm not so skilled when it comes to CSS. If you feel like it, please create a PR or write me what I could do better with the CSS.

And if you have other ideas, like about new automatic recommendations, let me know!

KristjanESPERANTO commented 4 months ago

I just created an issue about the CSS: https://github.com/KristjanESPERANTO/MagicMirror-3rd-Party-Modules/issues/6 :slightly_smiling_face:

Fabrizz commented 4 months ago

I just created an issue about the CSS: KristjanESPERANTO/MagicMirror-3rd-Party-Modules#6 🙂

I will look at it, maybe if I have some time I can send you a PR!

KristjanESPERANTO commented 4 months ago

That would be great! I've already made a few CSS changes, but there's definitely still a lot of room for improvement.