Replacing text_data with a translated string will being replaced again if its the same as another one

FabulousCupcake / umamusume-db-translate

Translate Umamusume by patching master.mdb

Creative Commons Zero v1.0 Universal

51 stars 33 forks source link

Replacing text_data with a translated string will being replaced again if its the same as another one #13

Open Kotoki1337 opened 3 years ago

Kotoki1337 commented 3 years ago

Replacing トウカイテイオー to 帝王 in name.csv

Then it replaces the translated 帝王 to Teio・Emperor in title.csv

Solution I think: can use the category id to determine the string location, a single csv file replaces only the string within a single category

FabulousCupcake commented 3 years ago

we can use the category id to determine the string location, a single csv file replaces only the string within a single category

I've thought about this, but decided against it since it increases code complexity quite a bit and I'd like to keep simple.
I'll think about adding category constraint for each csv file and implement it when I have some time.

~~For now, as a workaround, you can keep a backup copy of the original master.mdb and run the tool only with the fresh file.~~
I see what you mean now. I wonder if the entire search and replace can be made into a single transaction. That would work too.