FabulousCupcake / umamusume-db-translate

Translate Umamusume by patching master.mdb
Creative Commons Zero v1.0 Universal
51 stars 33 forks source link

Translating other table data #17

Open shuyafaye opened 3 years ago

shuyafaye commented 3 years ago

Is it possible if I put up translations for other table data? E.g _race_jikkyocomment

Since the current ones seems like it only replace _textdata only.

FabulousCupcake commented 3 years ago

Where does this text get used? Is it the race live commentary?
Currently the tool only updates text_data table so it won't be as easy as adding a new csv file; need to update the page script.

FabulousCupcake commented 3 years ago

I'm concerned about the space constraint in the live commentary; it doesn't seem like it would show english text nicely since it will be too long and get cut off. What do you think? 🤔

shuyafaye commented 3 years ago

Yeah, I tried and it does look horrible. Does text resizing works for all text display? I saw you used the tag before.

FabulousCupcake commented 3 years ago

Unity rich text should work, but best way to find out is simply to try it out ingame.

shuyafaye commented 3 years ago

I figured out the characters voiceline's text is in _character_systemtext, but the text alignment and spacing is so damn hard to work with. High likely, this is because of the original japanese text file is fewer in characters compared to english. Any workaround to deal with this?

test1 test2 test3

FabulousCupcake commented 3 years ago

Nope; I've been looking for a way to not have the text break like that too; I'm not familiar with unity overall though so no luck so far

GEEKiDoS commented 3 years ago

I figured out the characters voiceline's text is in _character_systemtext, but the text alignment and spacing is so damn hard to work with. High likely, this is because of the original japanese text file is fewer in characters compared to english. Any workaround to deal with this?

test1 test2 test3

Change text with hooking will not break the line, but it will be cuted if it has more line than original text: 20210409231839

I made a simple project to do that in these days: https://github.com/GEEKiDoS/umamusume-localify

shuyafaye commented 3 years ago

@GEEKiDoS , can you provide more details on how to run yours for this patch?

GEEKiDoS commented 3 years ago

@GEEKiDoS , can you provide more details on how to run yours for this patch?

Sure, just download version.dll from release or compile it your self(Requires VS2019, to generate project just click generate.bat) and then grab config.json and localized_data folder from repo, then put all of them into umamusume game folder

edit: localized_data contains Chinese translation, use original_data then rename it to localized_data instead

GoldElysium commented 3 years ago

@GEEKiDoS , can you provide more details on how to run yours for this patch?

Sure, just download version.dll from release or compile it your self(Requires VS2019, to generate project just click generate.bat) and then grab config.json and localized_data folder from repo, then put all of them into umamusume game folder

edit: localized_data contains Chinese translation, use original_data then rename it to localized_data instead

Created a tool to convert this repo's translations to @GEEKiDoS's format. https://github.com/GoldElysium/umamusume-translation-converter