search

FabulousCupcake / umamusume-db-translate

Translate Umamusume by patching master.mdb
Creative Commons Zero v1.0 Universal
51 stars 33 forks source link

Misplaced comma error for miscellaneous.csv #77

Closed SimpleSandman closed 3 years ago

SimpleSandman commented 3 years ago

As GitHub shows, the comma in the middle of the statement, "8 - Profile, Dormitory", breaks comma-delimited convention. I assume removing the comma is what's desired since this represents a header row for the data grouped below it.

Ref: https://github.com/FabulousCupcake/umamusume-db-translate/blob/master/src/data/miscellaneous.csv#L3

FabulousCupcake commented 3 years ago

I assume removing the comma is what's desired since this represents a header row for the data grouped below it.

This is correct, csv doesn't allow comments and the csvtojson.jq looks for lines with two items, so they are ignored and essentially is a hacky way to add comments.

Still would be nice if we could use github's nice csv view for them though, without polluting data.json (or maybe it's fine)

SimpleSandman commented 3 years ago

After using my importer, I noticed it was actually complaining about the missing second field. Which since this format looks intentional, I'll close this issue myself