Inform about AntiGhost - Githubissues

Madis0 commented 2 years ago

Mod name

AntiGhost

Curseforge link

No response

What it does

Asks the server to resend the packets when glitching inside blocks

Why should it be in the modpack

Very useful in Hypixel and other 1.8 servers
Avoids having to relog

Why shouldn't it be in the modpack

People may:

not know it's there
not know what it does
not know when to use it
be afraid to use it #95
not want to bother with it as it takes long to type (compared to keybind)
may have actually been kicked from the server for wrong usage
misuse can be negative to servers (see Julien's comment below)

Also

This should be fixed for the most part by Mojang already
This seems to go against the principle of not having to learn what mods FO has

Additional details

See https://github.com/Fabulously-Optimized/fabulously-optimized/issues/316#issuecomment-1125160521 for a potential alternative to advertise by

RaptaG commented 2 years ago

Ghost blocks appear more often on low ping and not only in older MC version servers. Also ghost blocks appear in singleplayer mode too, so I believe this isn't a good idea

Madis0 commented 2 years ago

If I keep the mod, how could I advertise it for the right players at the right time? It is already mentioned in Mod Menu and the description. Making the text more noticable probably wouldn't help as there is lots of text anyway and people could forget it by the time they need it.

RaptaG commented 2 years ago

If I keep the mod, how could I advertise it for the right players at the right time? It is already mentioned in Mod Menu and the description. Making the text more noticable probably wouldn't help as there is lots of text anyway and people could forget it by the time they need it.

With the needed information, I am willing to write a full description in the wiki, including only necessary things

eyezahhhh commented 2 years ago

Is it only activated by command, rather than keybind? If so we could just add a keybind to the mod. That'll also make its presence more known to users changing their keybinds when they find it in the list.

Madis0 commented 2 years ago

There is a keybind - it defaults to G. FO disabled it since 2.x.x because users should not hold it down or hit it repeatedly, plus it was hit by an accident.

Julienraptor01 commented 2 years ago

There is a keybind - it defaults to G. FO disabled it since 2.x.x because users should not hold it down or hit it repeatedly, plus it was hit by an accident.

Maybe we should bind it to some key that is far on the right of the keyboard or to a function key like f10 (maybe not f10 due to fabrishot being on f9) or f12 because these can't be hit by accident.

Madis0 commented 2 years ago

F-keys suck on laptops and compact gaming keyboards. Besides, no matter what key it is, they still need to learn it and use it, how would I tackle that issue?

Julienraptor01 commented 2 years ago

Well antighost should either be more "advertised" (it's not what i exactly mean but I'm not sure how to say it) or removed because having it in if majority of people don't use it is against FO basic rules. And the fact people would have to learn something makes it even against the rules. But it's really useful in some case and if more people knew about it, it would be more used when needed. Personnally i have removed it from my own modpack because one of my friend used it to make my own server lag by spamming it (and yes he's now banned).

redbrain commented 2 years ago

I'm in favor of pruning the modpack a bit (I think it's getting a bit too large for its own good) and AntiGhost is a good place to start pruning. In a modpack about performance and beauty, AntiGhost doesn't really have a legitimate claim to exist. I'll post a larger pruning-focused issue later this week.

Laawer commented 2 years ago

Anti Gost fixes one of the most annoying bugs in Minecraft, happens a lot to players that plays in servers and a considerable number of times I don't see a reason to remove It besides "the modpack is way too big", It does not add lag nor delays the updates

Madis0 commented 2 years ago

I don't see a reason to remove It besides "the modpack is way too big", It does not add lag nor delays the updates

That's not the reason anyway

The question is: if kept, how to make users use this mod for the right purpose at the right time?

Laawer commented 2 years ago

how to make users use this mod for the right purpose at the right time? Maybe in the modpack descrition?

DioEgizio commented 2 years ago

I personally never used this mod, but it can cause pain b/c of some anticheats, so I'm favour of removing it

triphora commented 2 years ago

If FO is meant to be a mod that is usable on the client for multiplayer servers, AntiGhost is a must-have. Even vanilla servers can have this desync issue, and I experience it quite often. I don't think it should be removed.

Madis0 commented 2 years ago

Maybe in the modpack descrition?

The modpack description is already long (and mentions it... okay, somewhat) and while I have plans to shorten it, I don't think mentioning this there should be a goal in itself, just keep it as a disclaimer.

I am thinking more contextual stuff like the TAB menu, the pause menu, the chat? And specific mod suggestions that would actually be able to achieve that.

quatquatt commented 2 years ago

I think this mod shows a lack of consistency in FO currently. Mods such as Beenfo, Chunky, and Suggestion Tweaker are rejected because they will only help a niche of players, but mods such as this are allowed. I think FO needs a clearer stance on mods that help the life of a certain niche of players. If AntiGhost is allowed to stay, I think that the pack should allow itself to open up to other QoL mods. However, if we remove AntiGhost, I think that should be the stance going forward on similar mods that only impact vanilla experience to make something easier.

Madis0 commented 2 years ago

I think this mod shows a lack of consistency in FO currently. Mods such as Beenfo, Chunky, and Suggestion Tweaker are rejected because they will only help a niche of players, but mods such as this are allowed. I think FO needs a clearer stance on mods that help the life of a certain niche of players. If AntiGhost is allowed to stay, I think that the pack should allow itself to open up to other QoL mods. However, if we remove AntiGhost, I think that should be the stance going forward on similar mods that only impact vanilla experience to make something easier.

Let's clear some things up first:

AntiGhost was added at the beginning of FO, in 2020. There were not a lot of mods that optimize the game at the time (except CaffeineMC's) so this was added as it seemed to be a good idea.
AntiGhost does help a lot in 1.8 servers, which the majority of the players (still) play in, even if only time to time. So, not exactly niche, just need to know when and how to use it.
Beenfo is currently not rejected. I think I will add it, just want to do some testing for it and resolve some other FO things first.
Chunky is server-side, which is not really the goal of FO, it seems complicated to use and I don't see how it would help in singleplayer
Suggestion Tweaker helps a limited amount of people using creative commands, so it does seem niche to me
The pack already is open (and has!) to QoL mods, you might be interested in this discussion: https://discord.com/channels/859124104644788234/859124543712133130/973219951114592337 It's rather about the scope of the QoL mods I add, it must not derive too much from vanilla.
I appreciate the criticism, but it is not that easy to make decisions when they are controversial :grin:

quatquatt commented 2 years ago

All very understandable! I knew that about Chunky, it just slipped my mind. And yeah I agree with that take on QoL mods. I agree with other people in the discussion and think clarity on what exactly the mod does would help it (but then again that's what a wiki is for).

Madis0 commented 2 years ago

Here's one approach I could think of. The real thing would require the files of all ~120 languages in-game, but since it is just one row of text, the resourcepack would probably take way less than a megabyte in total.

The proof of concept is currently EN-US only, feel free to try different text variations to improve it. And no, vanilla doesn't like newlines, otherwise I would've used that. AntiGhost reminder.zip

isXander commented 2 years ago

Maybe the issue you have to learn the mod is actually the mods fault. Instead, an improved mod that automatically updates ghost blocks if you lag back.

Alternatively, Fix the underlying bug where blocks desync.

Madis0 commented 2 years ago

Instead, an improved mod that automatically updates ghost blocks if you lag back.

That would be great and it actually has been suggested to AntiGhost, but he was not able to resolve it properly.

Fix the underlying bug where blocks desync.

That has already been claimed to be fixed by Mojang, but ViaVersion is different...

isXander commented 2 years ago

Instead, an improved mod that automatically updates ghost blocks if you lag back.

That would be great and it actually has been suggested to AntiGhost, but he was not able to resolve it properly.

Fix the underlying bug where blocks desync.

That has already been claimed to be fixed by Mojang, but ViaVersion is different...

Has a bug report been made to via version?

triphora commented 2 years ago

The issue is not exclusive to ViaVersion servers. I have gotten the issue on 1.18.2 servers using a 1.18.2 client.

RaptaG commented 2 years ago

Here's one approach I could think of. The real thing would require the files of all ~120 languages in-game, but since it is just one row of text, the resourcepack would probably take way less than a megabyte in total.

The proof of concept is currently EN-US only, feel free to try different text variations to improve it. And no, vanilla doesn't like newlines, otherwise I would've used that.

I personally disagree with the RP addition because:

It would take a long time to translate this in all the MC supported languages, like you said
It would be annoying to see this message every time you pause the game

Madis0 commented 2 years ago

I personally disagree with the RP addition because:

It would take a long time to translate this in all the MC supported languages, like you said

It would be annoying to see this message every time you pause the game

Thanks for the feedback.

If I kept "Game Menu" translated, indeed it would require constant maintenance unfortunately. But if I didn't, the zip would probably optimize it as ~100 files with identical contents 😄
Good point, as it should be still rarely needed.

Madis0 commented 2 years ago

Maybe I will overhaul the main description after all and mention it there, it is long overdue... 🤔

isXander commented 2 years ago

Maybe something like main menu credits for the pause screen? Put it in grey text bottom right?

Madis0 commented 2 years ago

Maybe something like main menu credits for the pause screen? Put it in grey text bottom right?

That could work, but is it worth adding an another mod for it...

RaptaG commented 2 years ago

That could work, but is it worth adding an another mod for it...

Maybe adding an extra feature in Main Menu Credits could be an option

isXander commented 2 years ago

Main Menu Credits

Remember, text objects can also be translation keys for different languages.

Madis0 commented 2 years ago

Main Menu Credits

Okay, that's cool. I hope it didn't affect the mod too much (e.g. don't mixin that view unless there is text to insert).

Remember, text objects can also be translation keys for different languages.

I'm aware that I can use existing ones but you're saying that I can also create new ones? Can I create random scope ones (e.g. put it next to other mod menu strings) or would it have to adhere to this mod's package?

isXander commented 2 years ago

Not sure. You would probably have to do this under assets/isxander-main-menu-credits

RaptaG commented 2 years ago

Main Menu Credits

Remember, text objects can also be translation keys for different languages.

Is it toggleable?

isXander commented 2 years ago

No. You can delete if from the config like anything else.

Optionally, madis0 can make a mod and use the runtime API and make the mod optional.

Madis0 commented 2 years ago

I would make it gray like in that picture so it would be minimally obtrusive but no, I don't think a toggle would be needed for this.

Easiest way to get rid of it would indeed be disabling the whole mod, blanking or deleting its config. But otherwise I still think it would add more value than annoyance in my opinion because it doesn't have the limits of the resource pack approach.

osfanbuff63 commented 2 years ago

I do not think this should be removed. This has come in handy so many times that it's not even funny lol.

I assume you can manually bind the keybind? If you wanted it for some reason

Madis0 commented 2 years ago

I do not think this should be removed. This has come in handy so many times that it's not even funny lol.

I assume you can manually bind the keybind? If you wanted it for some reason

Thanks for the input. As said before, there already was a keybind, but it was too easy to hit by accident and I did not see that switching to a different key would really fix the core problem.

Right now I think that Xander's solution is the best, just waiting for the mod to update now, so I can test it.

RaptaG commented 2 years ago

Pause Menu Credits added: https://github.com/isXander/main-menu-credits/releases/tag/1.1.0

isXander commented 2 years ago

Broken atm. Need to release hotfix.

Fabulously-Optimized / fabulously-optimized

Inform about AntiGhost #316

Mod name

Curseforge link

Other links

What it does

Why should it be in the modpack

Why shouldn't it be in the modpack

Categories

Additional details