Some mods may not have MMH description

[Madis0]

Describe the bug

More Culling does not show a custom description by Mod Menu Helper, despite it being included in the file.

Edit: as of 4.1.0-beta.1, it affects AdvancementInfo instead.

Modpack version

4.0.0-beta.11

Launcher

CurseForge Launcher

Other things

• [ ] I updated FO to a newer version (mention, what version to what version)
• [ ] I added/removed some mods or resource packs (mention, which ones)

Additional context

This is because the mod somehow applies its translated description after the Mod Menu Helper resource pack, or the resource pack just fails to overwrite it.

Relevant things that may help:

https://minecraft.fandom.com/wiki/Java_Edition_22w11a#General https://misode.github.io/pack-mcmeta/

[Madis0]

Everything actually works now that I PRed the fix upstream, I just forgot to include the line lmao

[Madis0]

Resolved in beta 12.

[Madis0]

The issue appears again with 4.1.0-beta.1 and AdvancementInfo. A fix has been suggested for Mod Menu. https://github.com/TerraformersMC/ModMenu/issues/480

[Madis0]

Turns out that LanguageReload also has a string of this kind, but MMH somehow still manages to override it... https://github.com/Jerozgen/LanguageReload/blob/master/src/main/resources/assets/languagereload/lang/en_us.json#L7

[Madis0]

Fixed in v4.4.6 thanks to Mod Menu folks

the tl;dr is that if you want to change some language strings you don't have to use the mod's namespace (root folder name) the same way you would when you change the textures just use a custom namespace like fo

[Madis0]

4.7.0-alpha.4, Russian only

[Madis0]

Present as of 4.7.0-beta.3, but I dunno how to fix, so I just updated the original issue and will untrack it from the project.